Updates/formatting to master_node_configuration #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adellape
added
the
peer-review-in-progress
There was a problem hiding this comment.
I tried to get this long sentence broken into two, but I think it's okay to leave it as one. However, I'd wrap that middle part in parentheses, not commas: "The command and its subcommands (master to launch a master server and node to launch a node server) all take a limited set of arguments that are sufficient for launching servers in a development or experimental environment."
|
I made a few notes for you, @adellape 👍 |
Contributor
Author
|
@tpoitras 🙇, will update. |
adellape
removed
the
peer-review-in-progress
adellape
force-pushed
the
master_node_config_edits
branch
from
0221116 to
c4b519d
Compare
Contributor
Author
|
@tpoitras Edits made per suggestions, thanks. |
Contributor
Author
adellape
added a commit
that referenced
this pull request
May 21, 2015
Updates/formatting to master_node_configuration
sbeskin-redhat
pushed a commit
to sbeskin-redhat/openshift-docs
that referenced
this pull request
Oct 24, 2022
…dule Consolidate installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liggitt @deads2k PTAL. For the example config files, I grabbed the output from a latest build today. Will probably update these again later, and figure out how to best provide descriptions the parameter stanzas. Will probably end up using callouts on the examples themselves, and use links to relevant topics where appropriate for more detailed usage.
Docs card: https://trello.com/c/acLPulJN