don't write project request template #2267
Conversation
deads2k
force-pushed
the
project-request-template
branch
from
42c983a to
e9f29e3
Compare
There was a problem hiding this comment.
I'm confused... this is submitting the template to the server to process? It doesn't actually persist anything, right? Does it matter what namespace we submit to as long as it exists?
There was a problem hiding this comment.
I'm confused... this is submitting the template to the server to process? It doesn't actually persist anything, right? Does it matter what namespace we submit to as long as it exists?
Correct on all counts and we happen to have a namespace that always exists.
There was a problem hiding this comment.
I thought the namespace you submitted to showed up in the objects in the resulting list... guess not
There was a problem hiding this comment.
I thought the namespace you submitted to showed up in the objects in the resulting list... guess not
Nope. I think they really wanted to have both namespaced and non-namespaced templates, but couldn't actually do that.
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/1959/) (Image: devenv-fedora_1536) |
re[merge] |
|
Evaluated for origin up to e9f29e3 |
Merged by openshift-bot
3 participants
As we discussed. If no template is provided in the config, ProjectRequest now operates against a default template that is not persisted. Setting the project request template field in the config overrides this default.
@liggitt