Skip to content

Comments

playbooks/init: Fix GCP job when oo_masters is not defined#12270

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.11from
mtnbikenc:fix-gcp-job
Nov 17, 2020
Merged

playbooks/init: Fix GCP job when oo_masters is not defined#12270
openshift-merge-robot merged 1 commit intoopenshift:release-3.11from
mtnbikenc:fix-gcp-job

Conversation

@mtnbikenc
Copy link
Member

https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-release-3.11-e2e-gcp

In no real world case would oo_masters be undefined. This only happens because of the way the GCP jobs piecemeal the cluster setup by calling individual playbooks.

@openshift-ci-robot
Copy link

@mtnbikenc: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

playbooks/init: Fix GCP job when oo_masters is not defined

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mtnbikenc,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelsmith
Copy link
Contributor

/retest

@mtnbikenc
Copy link
Member Author

The bot will automatically retest this as there is capacity.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Nov 17, 2020

/override e2e-aws
If this affected e2e-aws it would fail differently.

@openshift-ci-robot
Copy link

@sdodson: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/images
  • ci/prow/unit
  • tide
Details

In response to this:

/override e2e-aws
If this affected e2e-aws it would fail differently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Nov 17, 2020

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws

Details

In response to this:

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants