Expose NewWriter from internal for openshift-tests-extension#16
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:v2.19-openshift-4.18from Oct 8, 2024
Merged
Conversation
bertinatto
reviewed
Oct 8, 2024
Member
bertinatto
left a comment
bertinatto
left a comment
There was a problem hiding this comment.
/lgtm
I don't see a problem with exposing a new constructor, as this won't affect existing code not using it and it can be useful to write to anything other than stdout.
|
@bertinatto: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ginkgo's output writer hardcodes output to always go to os.Stdout, this exposes the NewWriter function so openshift-tests-extension can use it. This gives us more control over how we handle output from ginkgo, including writing it to `stderr` instead of `stdout`, or writing it to `io.Discard`, while maintaing the bytes buffer for returning output to OTE.
deads2k
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: bertinatto, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
dusk125
pushed a commit
to dusk125/onsi-ginkgo
that referenced
this pull request
Dec 5, 2024
Expose NewWriter from internal for openshift-tests-extension
dusk125
pushed a commit
to dusk125/onsi-ginkgo
that referenced
this pull request
Dec 5, 2024
Update suite.config.Timeout configuration logic for ginkgo v2.4 bump Make sure ginkgo.By is printed Merge pull request openshift#15 from stbenjam/labels Patch spec to allow access to labels for tests Merge pull request openshift#16 from stbenjam/writer Expose NewWriter from internal for openshift-tests-extension Remove bparees and soltysh from owners
jupierce
pushed a commit
that referenced
this pull request
Apr 16, 2025
Update suite.config.Timeout configuration logic for ginkgo v2.4 bump Make sure ginkgo.By is printed Merge pull request #15 from stbenjam/labels Patch spec to allow access to labels for tests Merge pull request #16 from stbenjam/writer Expose NewWriter from internal for openshift-tests-extension Remove bparees and soltysh from owners
jupierce
pushed a commit
that referenced
this pull request
Oct 1, 2025
Update suite.config.Timeout configuration logic for ginkgo v2.4 bump Make sure ginkgo.By is printed Merge pull request #15 from stbenjam/labels Patch spec to allow access to labels for tests Merge pull request #16 from stbenjam/writer Expose NewWriter from internal for openshift-tests-extension Remove bparees and soltysh from owners
jacobsee
added a commit
to jacobsee/onsi-ginkgo
that referenced
this pull request
Nov 20, 2025
Update suite.config.Timeout configuration logic for ginkgo v2.4 bump Make sure ginkgo.By is printed Merge pull request openshift#15 from stbenjam/labels Patch spec to allow access to labels for tests Merge pull request openshift#16 from stbenjam/writer Expose NewWriter from internal for openshift-tests-extension Remove bparees and soltysh from owners
jacobsee
added a commit
to jacobsee/onsi-ginkgo
that referenced
this pull request
Nov 20, 2025
Update suite.config.Timeout configuration logic for ginkgo v2.4 bump Make sure ginkgo.By is printed Merge pull request openshift#15 from stbenjam/labels Patch spec to allow access to labels for tests Merge pull request openshift#16 from stbenjam/writer Expose NewWriter from internal for openshift-tests-extension Remove bparees and soltysh from owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ginkgo's output writer hardcodes output to always go to os.Stdout, this exposes the NewWriter function so openshift-tests-extension can use it.
This gives us more control over how we handle output from ginkgo, including writing it to
stderrinstead ofstdout, or writing it toio.Discard, while maintaing the bytes buffer for returning output to OTE.