Write ginkgo output to stderr#10
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-eng:mainfrom Oct 8, 2024
Merged
Conversation
OTE was discarding the output ginkgo was writing to stdout -- this had the side-effect of throwing away the test's output. We want that to be stored in ExtensionTestResult. Now that I'm running some longer running kube tests, it was also a little weird we're silent for so long. This changes the behavior so we do include the tests output as it's generated, but it goes to stderr. This should make it easier for origin to consume the JSON result from stdout, but raw ginkgo test outputs still end up in the logs via stderr. Note: this relies on a patch to ginkgo to expose configuring the writer, stdout is hardcoded.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTE was discarding the output ginkgo was writing to stdout -- this had the side-effect of throwing away the test's output. We want that to be stored in ExtensionTestResult.
Now that I'm running some longer running kube tests, it was also a little weird we're silent for so long. This changes the behavior so we do include the tests output as it's generated, but it goes to stderr.
This should make it easier for origin to consume the JSON result from stdout, but raw ginkgo test outputs still end up in the logs via stderr.
Needs
openshift/onsi-ginkgo#16