Skip to content

Conversation

@dusk125
Copy link

@dusk125 dusk125 commented Dec 4, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 4, 2024
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these to your commit:

Update suite.config.Timeout configuration logic for ginkgo v2.4 bump

Make sure ginkgo.By is printed

Merge pull request openshift#15 from stbenjam/labels

Patch spec to allow access to labels for tests

Merge pull request openshift#16 from stbenjam/writer

Expose NewWriter from internal for openshift-tests-extension

Remove bparees and soltysh from owners
@dusk125 dusk125 force-pushed the v2.21-openshift-4.19 branch from bc6dd9c to 30fe238 Compare December 5, 2024 14:34
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 5, 2024
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2024

@bertinatto: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2024
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bertinatto, dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8006f30 into openshift:v2.21-openshift-4.19 Dec 5, 2024
@dusk125 dusk125 deleted the v2.21-openshift-4.19 branch December 5, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants