WRKLDS-1171: Add openshift-install-fips target to oc release extract#1725
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references WRKLDS-1171 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ardaguclu
left a comment
ardaguclu
left a comment
There was a problem hiding this comment.
/lgtm
/hold
in case you'd want to add TargetCommandName field and also it is better to see a green IPv6.
| Readme: readmeInstallUnix, | ||
| InjectReleaseImage: true, | ||
| InjectReleaseVersion: true, | ||
| ArchiveFormat: "openshift-baremetal-install-linux-%s.tar.gz", |
There was a problem hiding this comment.
Since this target's tarball name is same with the above one, there might be unexpected binary overrides. But I verified that --tools flag ignores the targets that are marked as Optional, so that these ArchiveFormats are not used at all and we are good.
There was a problem hiding this comment.
Thanks, I updated this one anyway.
| { | ||
| OS: "linux", | ||
| Arch: targetReleaseArch, | ||
| Command: "openshift-install-fips", |
There was a problem hiding this comment.
There is an option to change the resulted binary name by using TargetCommandName as in
oc/pkg/cli/admin/release/extract_tools.go
Line 279 in 425af75
openshift-install-fips.
There was a problem hiding this comment.
I think that's what we want to minimise confusion, so I will leave it as is.
|
/retest |
openshift-ci
bot
added
the
do-not-merge/hold
|
Just for the historical context, this will only work against 4.16 release payloads? or is this binary generated in 4.15 (probably not in the olders)? |
Allow the openshift-baremetal-install binary to also be extracted using the openshift-install-fips command. This is clearer for users who need this binary only for FIPS compliance reasons.
openshift-ci
bot
added
the
approved
It's the same binary as openshift-baremetal-installer, so it has been there since 4.4 or something. |
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-cli-container-v4.16.0-202404050447.p0.g1f5e247.assembly.stream.el8 for distgit openshift-enterprise-cli. |
4 participants
Allow the openshift-baremetal-install binary to also be extracted using the openshift-install-fips command. This is clearer for users who need this binary only for FIPS compliance reasons.