Skip to content

CORS-3446: Add instructions for obtaining correct binary#8230

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
zaneb:binary-location
Apr 8, 2024
Merged

CORS-3446: Add instructions for obtaining correct binary#8230
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
zaneb:binary-location

Conversation

@zaneb
Copy link
Member

@zaneb zaneb commented Apr 4, 2024

Update the warning message from the hostcrypt check to give more specific instructions on how to obtain the correct binary and where to run it.

Update the warning message from the hostcrypt check to give more
specific instructions on how to obtain the correct binary and where to
run it.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2024

@zaneb: This pull request references CORS-3446 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Update the warning message from the hostcrypt check to give more specific instructions on how to obtain the correct binary and where to run it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zaneb
Copy link
Member Author

zaneb commented Apr 4, 2024

/hold
Wait for openshift/oc#1725

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@openshift-ci openshift-ci bot requested review from bfournie and patrickdillon April 4, 2024 04:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

@zaneb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 2e19d44 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb
Copy link
Member Author

zaneb commented Apr 5, 2024

/hold cancel
/cc @r4f4

@openshift-ci openshift-ci bot requested a review from r4f4 April 5, 2024 09:05
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 5, 2024

Tried on a non-fips host:

WARNING target cluster is in FIPS mode, use the FIPS-capable installer binary for RHEL 8 on a host with FIPS enabled.
WARNING To obtain a suitable binary, download the openshift-install-rhel8 archive from the client mirror, or extract the openshift-install-fips command from the release payload.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 5, 2024

Compiled with the libvirt tag:

WARNING target cluster is in FIPS mode, enable FIPS mode on the host

@sadasu
Copy link
Contributor

sadasu commented Apr 8, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 911203d into openshift:master Apr 8, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404090113.p0.g911203d.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants