Skip to content

WRKLDS-1171: Add openshift-install-fips target to oc release extract #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 5, 2024
Merged

WRKLDS-1171: Add openshift-install-fips target to oc release extract #1725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/cli/admin/release/extract_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,18 @@ func (o *ExtractOptions) extractCommand(command string) error {
InjectReleaseVersion: true,
ArchiveFormat: "openshift-baremetal-install-linux-%s.tar.gz",
},
{
OS: "linux",
Arch: targetReleaseArch,
Command: "openshift-install-fips",
Copy link
Member

@ardaguclu ardaguclu Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an option to change the resulted binary name by using TargetCommandName as in

oc/pkg/cli/admin/release/extract_tools.go

Line 279 in 425af75

TargetCommandName: "oc",
, if you'd want to. Currently, it extracts openshift-install-fips.

Copy link
Member Author

@zaneb zaneb Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what we want to minimise confusion, so I will leave it as is.

Optional: true,
Mapping: extract.Mapping{Image: "baremetal-installer", From: "usr/bin/openshift-install"},

Readme: readmeInstallUnix,
InjectReleaseImage: true,
InjectReleaseVersion: true,
ArchiveFormat: "openshift-install-rhel-%s.tar.gz",
},
{
OS: "linux",
Arch: targetReleaseArch,
Expand Down