NO-JIRA: copy oc binary from cli-artifacts - #419
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jeffdyoung: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeffdyoung, sferich888 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
New changes are detected. LGTM label has been removed. |
| FROM registry.ci.openshift.org/ocp/4.16:cli | ||
| COPY --from=builder /go/src/github.com/openshift/must-gather/collection-scripts/* /usr/bin/ | ||
| COPY --from=cli-artifacts /usr/share/openshift/linux_amd64/oc.rhel8 /usr/bin/oc | ||
| COPY --from=cli-artifacts /usr/bin/oc /usr/bin/oc |
There was a problem hiding this comment.
@sferich888 we don't have to copy a specific oc arch here. The cli-artifacts container has the rhel8 variant of oc in /usr/bin/oc. Since the build system builds on native HW, we will always get the right binary arch.
There was a problem hiding this comment.
We are trying to change the default oc's base image to RHEL9 and default oc in cli-artifacts will also not work on must-gather.
/hold
jeffdyoung
changed the title
|
@jeffdyoung: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
closing in favor of #420 |
4 participants
additional work for #418 to copy multi-arch oc binaries.