Skip to content

Conversation

@Nikokolas3270
Copy link
Contributor

What type of PR is this?

feature

What this PR does / why we need it?

Adds the ack configs for 4.13

Which Jira/Github issue(s) this PR fixes?

relates tp OSD-15224

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2023

@Nikokolas3270: This pull request references OSD-15224 which is a valid jira issue.

Details

In response to this:

What type of PR is this?

feature

What this PR does / why we need it?

Adds the ack configs for 4.13

Which Jira/Github issue(s) this PR fixes?

relates tp OSD-15224

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nikokolas3270
Copy link
Contributor Author

Similar pull request for 4.12: #1343

Admin acks are now supported at OCP level thanks to this PR: openshift/cluster-version-operator#908

@RaphaelBut
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@zmird-r
Copy link
Contributor

zmird-r commented Mar 13, 2023

/lgtm

@cblecker
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, Nikokolas3270, RaphaelBut, zmird-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1617d7f into openshift:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants