Skip to content

Add admin/sts acks for 4.12#1343

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
cblecker:4.12-acks
Nov 23, 2022
Merged

Add admin/sts acks for 4.12#1343
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
cblecker:4.12-acks

Conversation

@cblecker
Copy link
Member

@cblecker cblecker commented Nov 22, 2022

What type of PR is this?

feature

What this PR does / why we need it?

Adds the ack configs for 4.12

relates to OSD-14014 OSD-14015

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@iamkirkbater
Copy link
Contributor

Looks sane to me.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cblecker,iamkirkbater]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 24d3209 into openshift:master Nov 23, 2022
@cblecker cblecker deleted the 4.12-acks branch November 23, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants