OCPBUGS-8304: Adding admin-gate ack-4.12-kube-1.26-api-removals-in-4.13 #908

LalatenduMohanty · 2023-03-03T16:06:31Z

No description provided.

openshift-ci · 2023-03-03T16:06:35Z

@LalatenduMohanty: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-8304: Adding admin-gate ack-4.12-kube-1.26-api-removals-in-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-03T16:06:39Z

@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-8304, which is invalid:

expected Jira Issue OCPBUGS-8304 to depend on a bug targeting a version in 4.13.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty · 2023-03-03T16:12:07Z

/jira refresh

openshift-ci-robot · 2023-03-03T16:12:10Z

@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-8304, which is invalid:

expected dependent Jira Issue OCPBUGS-8302 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is Closed (Not a Bug) instead
expected dependent Jira Issue OCPBUGS-8302 to target a version in 4.13.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty · 2023-03-03T16:14:11Z

/jira refresh

openshift-ci-robot · 2023-03-03T16:14:13Z

@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-8304, which is invalid:

expected dependent Jira Issue OCPBUGS-8302 to target a version in 4.13.0, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty · 2023-03-03T16:14:51Z

/jira refresh

openshift-ci-robot · 2023-03-03T16:15:00Z

@LalatenduMohanty: This pull request references Jira Issue OCPBUGS-8304, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-8302 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-8302 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @evakhoni

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml

wking

/lgtm

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty · 2023-03-06T15:18:15Z

/test ci/prow/unit

openshift-ci · 2023-03-06T15:18:59Z

@LalatenduMohanty: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-agnostic
/test e2e-agnostic-operator
/test e2e-agnostic-upgrade-into-change
/test e2e-agnostic-upgrade-out-of-change
/test gofmt
/test images
/test lint
/test unit

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-version-operator-release-4.12-e2e-agnostic
pull-ci-openshift-cluster-version-operator-release-4.12-e2e-agnostic-operator
pull-ci-openshift-cluster-version-operator-release-4.12-e2e-agnostic-upgrade-into-change
pull-ci-openshift-cluster-version-operator-release-4.12-e2e-agnostic-upgrade-out-of-change
pull-ci-openshift-cluster-version-operator-release-4.12-images
pull-ci-openshift-cluster-version-operator-release-4.12-unit

Details

In response to this:

/test ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LalatenduMohanty · 2023-03-06T15:19:15Z

/test unit

LalatenduMohanty · 2023-03-06T15:56:35Z

/test unit

DavidHurta

Looks good!

Data is indented correctly resulting in ack-4.12-kube-1.26-api-removals-in-4.13 being a child of data.

$  git cat-file -p PR908:install/0000_00_cluster-version-operator_01_admingate_configmap.yaml | yq -o=json
{
  "apiVersion": "v1",
  "kind": "ConfigMap",
  "data": {
    "ack-4.12-kube-1.26-api-removals-in-4.13": "Kubernetes 1.26 and therefore OpenShift 4.13 remove several APIs which require admin consideration. Please see the knowledge article https://access.redhat.com/articles/6958394 for details and instructions."
  },
  "metadata": {
    "name": "admin-gates",
    "namespace": "openshift-config-managed",
    "annotations": {
      "kubernetes.io/description": "Define update gates for the administrator to acknowledge in the admin-acks ConfigMap in the openshift-config namespace.",
      "include.release.openshift.io/ibm-cloud-managed": "true",
      "include.release.openshift.io/self-managed-high-availability": "true"
    }
  }
}

Using git diff --word-diff we can see only the necessary information was changed, and the Kubernetes version is correct (#908 (comment)).

$ git --no-pager diff --word-diff upstream/release-4.11..PR908  -- install/0000_00_cluster-version-operator_01_admingate_configmap.yaml
diff --git a/install/0000_00_cluster-version-operator_01_admingate_configmap.yaml b/install/0000_00_cluster-version-operator_01_admingate_configmap.yaml
index 6d897cfe..f468c907 100644
--- a/install/0000_00_cluster-version-operator_01_admingate_configmap.yaml
+++ b/install/0000_00_cluster-version-operator_01_admingate_configmap.yaml
@@ -1,8 +1,8 @@
apiVersion: v1
kind: ConfigMap
data:
  [-ack-4.11-kube-1.25-api-removals-in-4.12:-]{+ack-4.12-kube-1.26-api-removals-in-4.13:+} |-
      Kubernetes [-1.25-]{+1.26+} and therefore OpenShift [-4.12-]{+4.13+} remove several APIs which require admin consideration. Please see the knowledge article [-https://access.redhat.com/articles/6955381-]{+https://access.redhat.com/articles/6958394+} for details and instructions.
metadata:
  name: admin-gates
  namespace: openshift-config-managed

openshift-ci · 2023-03-06T19:32:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Davoska, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LalatenduMohanty · 2023-03-06T21:21:22Z

/test e2e-agnostic-upgrade-into-change e2e-agnostic-upgrade-out-of-change

wking · 2023-03-07T02:53:58Z

KubeStatefulSetReplicasMismatch firing is unrelated.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2023-03-07T02:54:25Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

KubeStatefulSetReplicasMismatch firing is unrelated.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-03-07T02:54:27Z

@LalatenduMohanty: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-upgrade-out-of-change	`2234774`	link	true	`/test e2e-agnostic-upgrade-out-of-change`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LalatenduMohanty · 2023-03-07T13:44:56Z

/label backport-risk-assessed

LalatenduMohanty · 2023-03-07T13:45:47Z

@evakhoni can you add the cherry-pick-approved labels

shellyyang1989 · 2023-03-07T14:11:38Z

@evakhoni can you add the cherry-pick-approved labels

I'm afraid Evgeni and I don't have permission. @jianlinliu could you please help with it?

jianlinliu · 2023-03-08T01:38:43Z

/label cherry-pick-approved

openshift-ci-robot · 2023-03-08T01:42:22Z

@LalatenduMohanty: Jira Issue OCPBUGS-8304: All pull requests linked via external trackers have merged:

openshift/cluster-version-operator#908

Jira Issue OCPBUGS-8304 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested a review from wking March 3, 2023 16:07

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2023

LalatenduMohanty force-pushed the OCPBUGS-8304_4.12 branch from 69cfceb to 988c530 Compare March 3, 2023 16:10

openshift-ci bot requested a review from evakhoni March 3, 2023 16:15

LalatenduMohanty mentioned this pull request Mar 3, 2023

OCPBUGS-8304: Adding admin-gates: ack-4.12-kube-1.26-api-removals-in-4.13 #907

Closed

wking reviewed Mar 3, 2023

View reviewed changes

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml Outdated Show resolved Hide resolved

wking reviewed Mar 3, 2023

View reviewed changes

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml Outdated Show resolved Hide resolved

LalatenduMohanty force-pushed the OCPBUGS-8304_4.12 branch from 988c530 to 4730588 Compare March 3, 2023 18:58

wking approved these changes Mar 3, 2023

View reviewed changes

openshift-ci bot assigned wking Mar 3, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2023

evakhoni reviewed Mar 5, 2023

View reviewed changes

install/0000_00_cluster-version-operator_01_admingate_configmap.yaml Outdated Show resolved Hide resolved

OCPBUGS-8304: Adding admin-gate ack-4.12-kube-1.26-api-removals-in-4.13

2234774

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>

LalatenduMohanty force-pushed the OCPBUGS-8304_4.12 branch from 4730588 to 2234774 Compare March 6, 2023 15:04

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023

DavidHurta approved these changes Mar 6, 2023

View reviewed changes

openshift-ci bot assigned DavidHurta Mar 6, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 7, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 8, 2023

openshift-merge-robot merged commit f30edfb into openshift:release-4.12 Mar 8, 2023

Nikokolas3270 mentioned this pull request Mar 13, 2023

OSD-15224: Add sts acks for 4.13 openshift/managed-cluster-config#1529

Merged

3 tasks

OCPBUGS-8304: Adding admin-gate ack-4.12-kube-1.26-api-removals-in-4.13 #908

OCPBUGS-8304: Adding admin-gate ack-4.12-kube-1.26-api-removals-in-4.13 #908

Uh oh!

Conversation

LalatenduMohanty commented Mar 3, 2023

Uh oh!

openshift-ci bot commented Mar 3, 2023

Uh oh!

openshift-ci-robot commented Mar 3, 2023

Uh oh!

LalatenduMohanty commented Mar 3, 2023

Uh oh!

openshift-ci-robot commented Mar 3, 2023

Uh oh!

LalatenduMohanty commented Mar 3, 2023

Uh oh!

openshift-ci-robot commented Mar 3, 2023

Uh oh!

LalatenduMohanty commented Mar 3, 2023

Uh oh!

openshift-ci-robot commented Mar 3, 2023

Uh oh!

Uh oh!

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LalatenduMohanty commented Mar 6, 2023

Uh oh!

openshift-ci bot commented Mar 6, 2023

Uh oh!

LalatenduMohanty commented Mar 6, 2023

Uh oh!

LalatenduMohanty commented Mar 6, 2023

Uh oh!

DavidHurta left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 6, 2023

Uh oh!

LalatenduMohanty commented Mar 6, 2023

Uh oh!

wking commented Mar 7, 2023

Uh oh!

openshift-ci bot commented Mar 7, 2023

Uh oh!

openshift-ci bot commented Mar 7, 2023

Uh oh!

LalatenduMohanty commented Mar 7, 2023

Uh oh!

LalatenduMohanty commented Mar 7, 2023

Uh oh!

shellyyang1989 commented Mar 7, 2023

Uh oh!

jianlinliu commented Mar 8, 2023

Uh oh!

openshift-ci-robot commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants