Skip to content

MCO: add etcd-quorum-guard image #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
runcom wants to merge 1 commit into from
Closed

MCO: add etcd-quorum-guard image #633

runcom wants to merge 1 commit into from

Conversation

@runcom
Copy link
Member

@runcom runcom commented Apr 12, 2019

Needed to unblock openshift/installer#1597

Signed-off-by: Antonio Murdaca runcom@linux.com

@runcom runcom requested a review from cgwalters April 12, 2019 13:36
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom runcom mentioned this pull request Apr 12, 2019
Closed
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2019
@runcom
MCO: add etcd-quorum-guard image
c46bf77 
Needed to unblock openshift/installer#1597

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom
Copy link
Member Author

runcom commented Apr 12, 2019

Actually, re-following what we did for the InfraImage, this should go in with #613, merge that, then the installer PR is going to be merged, and then something like #518

omg, all of this is so silly

@RobertKrawitz
Copy link
Contributor

RobertKrawitz commented Apr 12, 2019

So should I merge this into #613?

@runcom
Copy link
Member Author

runcom commented Apr 12, 2019

I believe so, and on top of this, you should also do something similar to this https://github.com/openshift/machine-config-operator/pull/508/files (I'm resyncing with Colin on this but this is what I would do following what we did with the infra image)

RobertKrawitz
RobertKrawitz reviewed Apr 12, 2019
View reviewed changes
cmd/machine-config-operator/bootstrap.go
setupEtcdEnvImage string
infraImage string
kubeClientAgentImage string
etcdQuorumGuardImage string
Copy link
Contributor

@RobertKrawitz RobertKrawitz Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in #613

RobertKrawitz
RobertKrawitz reviewed Apr 12, 2019
View reviewed changes
cmd/machine-config-operator/bootstrap.go
bootstrapCmd.MarkFlagRequired("kube-client-agent-image")
bootstrapCmd.PersistentFlags().StringVar(&bootstrapOpts.infraImage, "infra-image", "", "Image for Infra Containers.")
bootstrapCmd.MarkFlagRequired("infra-image")
bootstrapCmd.PersistentFlags().StringVar(&bootstrapOpts.etcdQuorumGuardImage, "etcd-quorum-guard-image", "registry.svc.ci.openshift.org/openshift/origin-v4.0:base", "Image for etcd Quorum Guard.")
Copy link
Contributor

@RobertKrawitz RobertKrawitz Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already in #613 (including marking it required).

RobertKrawitz
RobertKrawitz reviewed Apr 12, 2019
View reviewed changes
install/image-references
from:
kind: DockerImage
name: quay.io/openshift/origin-pod:v4.0
- name: etcd-quorum-guard-image
Copy link
Contributor

@RobertKrawitz RobertKrawitz Apr 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added just now to #613.

@runcom runcom closed this Apr 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2019

@runcom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-op c46bf77 link /test e2e-aws-op
ci/prow/e2e-aws c46bf77 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RobertKrawitz
Copy link
Contributor

RobertKrawitz commented Apr 16, 2019

@runcom is this even needed any longer, as all of the changes are in #613?

@runcom
Copy link
Member Author

runcom commented Apr 16, 2019

@runcom is this even needed any longer, as all of the changes are in #613?

nope, this is closed since 4 days now, just tests rekicked for no good reason I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@jlebon jlebon Awaiting requested review from jlebon

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

1 more reviewer

@RobertKrawitz RobertKrawitz RobertKrawitz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@runcom @openshift-ci-robot @RobertKrawitz