Skip to content

Add etcd-quorum-guard #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RobertKrawitz wants to merge 2 commits into from
Closed

Add etcd-quorum-guard #1597

RobertKrawitz wants to merge 2 commits into from

Conversation

@RobertKrawitz
Copy link
Contributor

@RobertKrawitz RobertKrawitz commented Apr 11, 2019

Add etcd-quorum-guard.
xref openshift/machine-config-operator#613

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@RobertKrawitz RobertKrawitz mentioned this pull request Apr 11, 2019
Closed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobertKrawitz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: flaper87

If they are not already assigned, you can assign the PR to them by writing /assign @flaper87 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

abhinavdahiya
abhinavdahiya suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required pods is only the control plane please drop etcd quorum guard from the list.

@RobertKrawitz
Copy link
Contributor Author

RobertKrawitz commented Apr 11, 2019

The required pods is only the control plane please drop etcd quorum guard from the list.

In that case, is this PR even needed at all?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2019

@RobertKrawitz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws e92cf99 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@runcom runcom mentioned this pull request Apr 12, 2019
Closed
runcom added a commit to runcom/machine-config-operator that referenced this pull request Apr 12, 2019
@runcom
MCO: add etcd-quorum-guard image
c46bf77 
Needed to unblock openshift/installer#1597

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@RobertKrawitz
Copy link
Contributor Author

RobertKrawitz commented Apr 16, 2019

No longer appears necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staebler staebler Awaiting requested review from staebler

@wking wking Awaiting requested review from wking

1 more reviewer

@abhinavdahiya abhinavdahiya abhinavdahiya requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertKrawitz @openshift-ci-robot @abhinavdahiya