Skip to content

bootstrap: Final switch to CVO pod image #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 2, 2019
Merged

bootstrap: Final switch to CVO pod image #518

openshift-merge-robot merged 1 commit into from
Mar 2, 2019

Conversation

@cgwalters
Copy link
Member

@cgwalters cgwalters commented Mar 1, 2019

When openshift/installer#1292 lands
this will undo the hacks to enable the CVO-driven pod image.

@cgwalters
bootstrap: Final switch to CVO pod image
ad72ddf 
When openshift/installer#1292 lands
this will undo the hacks to enable the CVO-driven pod image.
@cgwalters cgwalters added the 4.0 label Mar 1, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2019
@cgwalters cgwalters mentioned this pull request Mar 1, 2019
Merged
ashcrow
ashcrow approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Is this safe to merge before openshift/installer#1292? Or should it wait?

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 1, 2019

This merges after the installer PR merges.

@ashcrow
Copy link
Member

ashcrow commented Mar 1, 2019 •
edited
Loading

/hold

Remove the hold once the required PR for the installer is in place.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 1, 2019

/retest

@cgwalters
Copy link
Member Author

cgwalters commented Mar 1, 2019

/hold cancel

Installer PR went in, this should just need a lgtm.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ashcrow,cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

cgwalters commented Mar 1, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 51d77bc into openshift:master Mar 2, 2019
This was referenced Apr 12, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow ashcrow approved these changes

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cgwalters @kikisdeliveryservice @ashcrow @openshift-ci-robot @openshift-bot @openshift-merge-robot