Skip to content

BUG 1670700: *: add etcd-metric-ca flag #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 29, 2019
Merged

BUG 1670700: *: add etcd-metric-ca flag #590

openshift-merge-robot merged 1 commit into from
Mar 29, 2019

Conversation

@hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Mar 27, 2019

This PR is the first of 2 the default is set for chicken and egg with the installer. Adding the metric ca is part of a series of PRs to add etcd metric support.

Depends on openshift/installer#1477

/hold

@hexfusion
*: add etcd-metric-ca flag
39b10d0 
This PR is the first of 2 the default is set for chicken and egg with installer.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

/retest

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

/test e2e-aws

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

Dependency openshift/installer#1477 has merged

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2019
@runcom
Copy link
Member

runcom commented Mar 28, 2019

Wait is this fixing any bug as we're post feature freeze

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

etcd does not have metric support by default without this and a few others. This was originally 4.0 but scheduling has changed. Still, a fair amount of work to get this landed so I am not sure honestly.

/cc @brancz @abhinavdahiya

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

This is part of https://jira.coreos.com/browse/PROD-939

@runcom
Copy link
Member

runcom commented Mar 28, 2019

This is part of https://jira.coreos.com/browse/PROD-939

ack, let's wait for an official ACK I'd say

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

This is the primary bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1670700

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 28, 2019

/test e2e-aws-op

@hexfusion hexfusion changed the title *: add etcd-metric-ca flag BUG 1670700: *: add etcd-metric-ca flag Mar 28, 2019
@s-urbaniak
Copy link
Contributor

s-urbaniak commented Mar 29, 2019

/approve
see openshift/installer#1483 (review) for more rationale.

@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 29, 2019

@runcom we should be clear now ^^
/retest

@runcom
Copy link
Member

runcom commented Mar 29, 2019

/hold cancel

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 29, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, runcom, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2019
@hexfusion
Copy link
Contributor Author

hexfusion commented Mar 29, 2019

/test e2e-aws-op

@openshift-merge-robot openshift-merge-robot merged commit 3444ce6 into openshift:master Mar 29, 2019
@hexfusion hexfusion mentioned this pull request Apr 1, 2019
Merged
runcom added a commit to runcom/machine-config-operator that referenced this pull request Apr 2, 2019
@runcom
pkg/apis: update generated deepcopy
df3b5ac 
This PR openshift#590
didn't run `make update` and generated deepcopy hasn't been updated.
This PR just does that.

Signed-off-by: Antonio Murdaca <runcom@linux.com>
@runcom runcom mentioned this pull request Apr 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlebon jlebon Awaiting requested review from jlebon

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@brancz brancz Awaiting requested review from brancz

Assignees

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hexfusion @runcom @s-urbaniak @openshift-ci-robot @openshift-merge-robot