Skip to content

Conversation

@hexfusion
Copy link
Contributor

This PR adds metric-signer CA's to kube-etcd-signer-server as part of voyage to etcd metrics by default. The eventual result is the etcd static pod procuring TLS certs with a separate chain of trust vs Peer and Server .

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2019
@hexfusion
Copy link
Contributor Author

could not resolve inputs: could not determine inputs for step [input:root]: could not resolve base image: the server was unable to return a response in the time allotted, but may still be processing the request (get imagestreamtags.image.openshift.io release:golang-1.10)

/test unit

@hexfusion
Copy link
Contributor Author

/retest

@hexfusion hexfusion changed the title data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server BUG670700:data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server Mar 28, 2019
@abhinavdahiya abhinavdahiya changed the title BUG670700:data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server BUG 670700: data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server Mar 28, 2019
@hexfusion hexfusion changed the title BUG 670700: data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server BUG 1670700: data/data/bootstrap: set metric-ca flags for kube-etcd-signer-server Mar 28, 2019
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

As discussed out of band: this, and especially the other corresponding PR https://github.com/openshift/installer/pull/1291/files "just" changes the secret location (and adds a configmap for the CA) of the etcd client secrets/cert. The fact that they are proxied is an opaque fact for the cluster monitoring operator. Note that the CA has to be loaded from a configmap now and the secret location has to be changed in the code that was introduced in openshift/cluster-monitoring-operator#239

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, hexfusion, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit 554de6f into openshift:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants