Bug 2058626: Revert "Bump(openshift/api): to get CSI changes" #2968

jsafrane · 2022-02-25T16:40:43Z

This reverts commit 817e3a6 / PR #2949

It broke fsGroup in Prometheus Pods / PVs. See https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.11-e2e-azure/1496904660361940992 and https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2058626#c1

This reverts commit 817e3a6. It broke fsGroup in Prometheus Pods / PVs.

openshift-ci · 2022-02-25T16:41:03Z

@jsafrane: This pull request references Bugzilla bug 2058626, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2058626: Revert "Bump(openshift/api): to get CSI changes"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-25T16:41:48Z

@jsafrane: This pull request references Bugzilla bug 2058626, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.11.0) matches configured target release for branch (4.11.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 2058626: Revert "Bump(openshift/api): to get CSI changes"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang · 2022-02-25T16:47:45Z

cc @bertinatto

Should be a safe revert

jsafrane · 2022-02-25T16:54:26Z

/test e2e-azure

jsafrane · 2022-02-25T16:55:17Z

/test e2e-azure-upgrade
?

wking · 2022-02-25T17:50:28Z

e2e-azure:

INFO[2022-02-25T17:01:10Z] Running step e2e-azure-ipi-install-install.  
INFO[2022-02-25T17:37:10Z] Step e2e-azure-ipi-install-install succeeded after [36](https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2968/pull-ci-openshift-machine-config-operator-master-e2e-azure/1497253671023415296#1:build-log.txt%3A36)m0s.

Which is enough for me to be satisfied.

/lgtm

bertinatto · 2022-02-25T18:08:43Z

/lgtm
Just to add more context, this revert is intended to unblock CI and give us more time to fix the real issue.
We'll revert this revert in a few days.

openshift-ci · 2022-02-25T18:09:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, wking, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-02-25T18:23:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

wking · 2022-02-25T18:36:12Z

e2e-azure-upgrade launched from 4.11.0-0.ci.test-2022-02-25-165548 which had the broken code this PR reverts, and install failed as expected for those broken releases.

e2e-azure failed, but just on etcdHighNumberOfFailedGRPCRequests, which is a noisy alert for Azure, so fix confirmed.

e2e-agnostic-upgrade ran on Azure, and failed the same way as e2e-azure-upgrade. We probably need to /override ci/prow/e2e-agnostic-upgrade.

e2e-gcp-op is apparently required too, per the Tide message, and that's still running. But since this is a clean revert of the most-recently-landed PR, I have no problem just /override ...ing everything that's keeping this from merging.

openshift-bot · 2022-02-25T18:47:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

yuqi-zhang · 2022-02-25T18:51:10Z

Given trevor's assessment, and looking at the various failures starting when #2949 merged, there's enough correlational evidence to believe that the e2e-agnostic upgrades are failing due to the install failing due to the previous PR.

Overriding just that test (and it should be a safe operation anyways. There are no successful e2e-upgrades on azure so this can't make it worse)

/override ci/prow/e2e-agnostic-upgrade

openshift-ci · 2022-02-25T18:51:43Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

Given trevor's assessment, and looking at the various failures starting when #2949 merged, there's enough correlational evidence to believe that the e2e-agnostic upgrades are failing due to the install failing due to the previous PR.

Overriding just that test (and it should be a safe operation anyways. There are no successful e2e-upgrades on azure so this can't make it worse)

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-25T19:09:07Z

@jsafrane: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#2968

Bugzilla bug 2058626 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2058626: Revert "Bump(openshift/api): to get CSI changes"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-02-25T19:09:24Z

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-upgrade	`8d484e1`	link	false	`/test e2e-azure-upgrade`
ci/prow/e2e-ovn-step-registry	`8d484e1`	link	false	`/test e2e-ovn-step-registry`
ci/prow/e2e-aws-upgrade-single-node	`8d484e1`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-gcp-op-single-node	`8d484e1`	link	false	`/test e2e-gcp-op-single-node`
ci/prow/e2e-aws-single-node	`8d484e1`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-workers-rhel8	`8d484e1`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-azure	`8d484e1`	link	false	`/test e2e-azure`
ci/prow/e2e-metal-ipi	`8d484e1`	link	false	`/test e2e-metal-ipi`
ci/prow/e2e-aws-workers-rhel7	`8d484e1`	link	false	`/test e2e-aws-workers-rhel7`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gnufied · 2022-02-25T19:44:59Z

@yuqi-zhang @bertinatto @wking how do we ensure that nobody else bumps the api while we fix CSIDriver issue for real? Will adding a comment to go.mod help?

yuqi-zhang · 2022-02-28T17:39:01Z

@yuqi-zhang @bertinatto @wking how do we ensure that nobody else bumps the api while we fix CSIDriver issue for real? Will adding a comment to go.mod help?

Depends on how long we foresee the fix taking. If its in the next few weeks, we can probably just be careful

Revert "Bump(openshift/api): to get CSI changes"

8d484e1

This reverts commit 817e3a6. It broke fsGroup in Prometheus Pods / PVs.

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 25, 2022

openshift-ci bot requested review from cheesesashimi and jkyros February 25, 2022 16:41

yuqi-zhang approved these changes Feb 25, 2022

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2022

openshift-ci bot assigned wking Feb 25, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2022

openshift-ci bot assigned bertinatto Feb 25, 2022

openshift-merge-robot merged commit 4e7fe38 into openshift:master Feb 25, 2022

jrvaldes mentioned this pull request Feb 25, 2022

Revert "WINC-607: [build] Install jq in CI Dockerfile" openshift/windows-machine-config-operator#934

Merged

thunderboltsid mentioned this pull request Mar 1, 2022

Add Nutanix Platform to Machine Config Operator #2942

Merged

Bug 2058626: Revert "Bump(openshift/api): to get CSI changes" #2968

Bug 2058626: Revert "Bump(openshift/api): to get CSI changes" #2968

Uh oh!

Conversation

jsafrane commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

yuqi-zhang commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Feb 25, 2022

Uh oh!

jsafrane commented Feb 25, 2022

Uh oh!

wking commented Feb 25, 2022

Uh oh!

bertinatto commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

openshift-bot commented Feb 25, 2022

Uh oh!

wking commented Feb 25, 2022

Uh oh!

openshift-bot commented Feb 25, 2022

Uh oh!

yuqi-zhang commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

gnufied commented Feb 25, 2022

Uh oh!

yuqi-zhang commented Feb 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jsafrane commented Feb 25, 2022 •

edited

Loading

yuqi-zhang commented Feb 25, 2022 •

edited

Loading