Skip to content

Bump(openshift/api): to get CSI changes #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 24, 2022
Merged

Bump(openshift/api): to get CSI changes #2949

openshift-merge-robot merged 1 commit into from
Feb 24, 2022

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Feb 9, 2022 •
edited by kikisdeliveryservice
Loading

In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder.
As a result, we need to stop force-disabling the feature gates because
that doesn't have any effect anymore.

CC @openshift/storage

@bertinatto bertinatto force-pushed the bump-api-azure-cinder-csi-migration-on branch from dc8cbaf to 576c514 Compare February 9, 2022 19:24
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 9, 2022

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2022

@kikisdeliveryservice: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-gcp-op
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test bootstrap-unit
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel7
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-master-bootstrap-unit
  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-upgrade-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel8
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op-single-node
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 9, 2022

/test e2e-openstack
/test e2e-metal-ipi
/test e2e-gcp-upgrade

@bertinatto
Copy link
Member Author

bertinatto commented Feb 10, 2022

/retest

@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Feb 10, 2022

Could you add some context to the commit message? For example, why some featuregates are being removed

@bertinatto
Bump(openshift/api): to get CSI changes
817e3a6 
In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder.
As a result, we need to stop force-disabling the feature gates because
that doesn't have any effect anymore.
@bertinatto bertinatto force-pushed the bump-api-azure-cinder-csi-migration-on branch from 576c514 to 817e3a6 Compare February 11, 2022 12:22
@bertinatto
Copy link
Member Author

bertinatto commented Feb 11, 2022

Could you add some context to the commit message? For example, why some featuregates are being removed

I amended the commit message to add context for the CSI changes, however, I don't know all the details for all the other changes in openshift/api.

@bertinatto
Copy link
Member Author

bertinatto commented Feb 14, 2022

/retest

1 similar comment
@bertinatto
Copy link
Member Author

bertinatto commented Feb 14, 2022

/retest

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 14, 2022

weird, i thought this ran:
/test e2e-openstack

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 14, 2022

@bertinatto can you assign some non-mco reviewers for this who have some background to review his change?

@jsafrane
Copy link
Contributor

jsafrane commented Feb 15, 2022

/lgtm
from storage team POV

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 16, 2022

Since the commit references openstack as well, @mandre @pierreprinetti would be mind just taking a quick look on this?

mandre
mandre reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the commit references openstack as well, @mandre @pierreprinetti would be mind just taking a quick look on this?

LGTM, as far as OpenStack platform is concerned.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 23, 2022

@rphillips re: non-CSI featuregate changes, do these look ok?

@rphillips
Copy link
Contributor

rphillips commented Feb 23, 2022

/lgtm

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 23, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, kikisdeliveryservice, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2022 •
edited
Loading

@bertinatto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-upgrade 576c514542ec0f3c39cb946e75e3345b769e023c link false /test e2e-gcp-upgrade
ci/prow/e2e-aws-disruptive 817e3a6 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-single-node 817e3a6 link false /test e2e-aws-single-node
ci/prow/e2e-aws-upgrade-single-node 817e3a6 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-workers-rhel8 817e3a6 link false /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 846ee71 into openshift:master Feb 24, 2022
@jsafrane jsafrane mentioned this pull request Feb 25, 2022
Merged
@jsafrane jsafrane mentioned this pull request Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rphillips rphillips

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bertinatto @kikisdeliveryservice @yuqi-zhang @jsafrane @rphillips @openshift-bot @mandre @openshift-merge-robot