Add Nutanix Platform to Machine Config Operator #2942

thunderboltsid · 2022-02-03T17:03:12Z

Update controllerconfig CRD and relevant switch statements
in pkg to handle Nutanix platform.

kikisdeliveryservice · 2022-02-04T18:15:12Z

/test verify
/test unit

pkg/operator/render.go

thunderboltsid · 2022-02-14T19:05:53Z

ci/prow/unit failures https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2942/pull-ci-openshift-machine-config-operator-master-unit/1493272225430638592 started happening when API dependency got updated.

thunderboltsid · 2022-02-14T20:54:49Z

ci/prow/unit failures https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2942/pull-ci-openshift-machine-config-operator-master-unit/1493272225430638592 started happening when API dependency got updated.

Trying to narrow down the offending commit. The unit tests don't fail when bumping the API dependency to 58db72a40994aaa03e79fd9d7ec791987a5fb1dc. However, when bumping it to the the commit next in chronological order de2aae00abd3f89af713a9c718eeb0ad1a12905c they start failing.

Failing tests:

--- FAIL: TestFeatureGateDrift (0.40s)
    --- FAIL: TestFeatureGateDrift/AWS (0.13s)
    --- FAIL: TestFeatureGateDrift/None (0.13s)
    --- FAIL: TestFeatureGateDrift/unrecognized (0.13s)

--- FAIL: TestFeaturesDefault (0.79s)
    --- FAIL: TestFeaturesDefault/AWS (0.26s)
    --- FAIL: TestFeaturesDefault/None (0.26s)
    --- FAIL: TestFeaturesDefault/unrecognized (0.26s)

--- FAIL: TestBootstrapFeaturesDefault (0.18s)
    --- FAIL: TestBootstrapFeaturesDefault/AWS (0.06s)
    --- FAIL: TestBootstrapFeaturesDefault/None (0.06s)
    --- FAIL: TestBootstrapFeaturesDefault/unrecognized (0.06s)

thunderboltsid · 2022-02-23T20:47:20Z

/retest

kikisdeliveryservice

would you mind squashing your newest commit(abca3c7e6251c0a8e86ab898b9619ec70118acca) into the prev one(e270c7d49fa9a3c5c108dfed3df0ef1652773cad)

templates/master/01-master-kubelet/_base/files/kubelet.yaml

go.mod

kikisdeliveryservice · 2022-02-23T23:58:21Z

adding a hold to let us get the api dependency sorted out between the 2 prs. once https://github.com/openshift/machine-config-operator/pull/2949/files lands shortly we can update this one.

/hold

thunderboltsid · 2022-02-24T14:24:20Z

would you mind squashing your newest commit(abca3c7) into the prev one(e270c7d)

Sure.

kikisdeliveryservice

Thanks for the updates @thunderboltsid

kikisdeliveryservice · 2022-02-24T18:31:26Z

Since they'll be approvers for this platform: @yanhua121 @adiantum can you PTAL

thunderboltsid · 2022-02-24T18:41:39Z

/retest

thunderboltsid · 2022-02-25T06:54:58Z

/retest-required

thunderboltsid · 2022-02-25T09:35:03Z

/retest-required

adiantum · 2022-02-25T11:30:22Z

Since they'll be approvers for this platform: @yanhua121 @adiantum can you PTAL

/lgtm

openshift-ci · 2022-02-25T11:30:50Z

@adiantum: changing LGTM is restricted to collaborators

Details

In response to this:

Since they'll be approvers for this platform: @yanhua121 @adiantum can you PTAL

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-03-22T02:59:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T03:11:02Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T03:23:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T03:35:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T09:36:01Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T10:02:03Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T10:38:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T11:38:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T12:26:13Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T13:38:05Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

thunderboltsid · 2022-03-22T14:55:13Z

/retest-required

openshift-bot · 2022-03-22T15:26:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T18:38:06Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T19:26:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-22T19:50:08Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice · 2022-03-22T20:14:17Z

There are some IAM issues that are causing some of these jobs to fail. I'll go investigate and put a hold on this for now to avoid us all getting spammed with retests and failures.

/hold

kikisdeliveryservice · 2022-03-22T20:19:08Z

/skip

kikisdeliveryservice · 2022-03-22T21:44:34Z

/hold cancel

kikisdeliveryservice · 2022-03-22T21:44:58Z

/test e2e-aws

openshift-bot · 2022-03-23T00:07:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T00:20:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-23T02:19:00Z

@thunderboltsid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-workers-rhel7	891ee12edb7f6087816b0a73ad4a4adfe1620d9a	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-workers-rhel8	`d2b2442`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-disruptive	`d2b2442`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-single-node	`d2b2442`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-aws-upgrade-single-node	`d2b2442`	link	false	`/test e2e-aws-upgrade-single-node`
ci/prow/e2e-vsphere-upgrade	`d2b2442`	link	false	`/test e2e-vsphere-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2022-03-23T03:14:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-23T04:04:36Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Discussion in [1] has some details, but trying to unpack "all on-prem IPI except baremetal IPI" into specifics, [2] is in an on-prem directory configuring keepalived, and it switches on onPremPlatformAPIServerInternalIP for enabled vs. disabled. onPremPlatformAPIServerInternalIP is true (enabling the keepalived configuration) for: * BareMetal (4.10 [3] and 4.11 [4]) * oVirt (4.10 [3] and 4.11 [4]) * OpenStack (4.10 [3] and 4.11 [4]) * VSphere (4.10 [3] and 4.11 [4]), * KubeVirt (4.10 [3], dropped in 4.11 [4,5]) * Nutanix (new in 4.11 [4,6,7]). Before 4.11, ENABLE_UNICAST was conditional on onPremPlatformKeepalivedEnableUnicast [8], but since 4.11, it has always been 'yes' [9]. The platforms that were unicast on 4.10's onPremPlatformKeepalivedEnableUnicast were BareMetal and KubeVirt [10]. Putting this all together, AWS and other platforms that don't match the onPremPlatformAPIServerInternalIP logic aren't impacted, because they don't enable the keepalived configuration. BareMetal is not impacted by 4.10-to-4.11 updates, because any to-unicast transition issues will already have been resolved by 4.10. Remaining onPremPlatformAPIServerInternalIP platforms which occur in both 4.10 and 4.11 are interested, and I match them here. Generated by writing the 4.11.0 declaration by hand, and then copying out to other 4.11 releases with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.11' | jq -r '.nodes[].version' | grep '^4[.]11[.]' | grep -v '^4[.]11[.]0$' | while read V; do sed "s/4[.]11[.]0/${V}/g" blocked-edges/4.11.0-KeepalivedMulticastSkew.yaml > "blocked-edges/${V}-KeepalivedMulticastSkew.yaml"; done $ git add blocked-edges/4.11.*KeepalivedMulticastSkew.yaml [1]: https://issues.redhat.com/browse/OPNET-296 [2]: https://github.com/openshift/machine-config-operator/blame/8fa0b7e8903226b3cfb76e6c6f49409cfc0dd0e7/templates/common/on-prem/files/keepalived.yaml#L2 [3]: https://github.com/openshift/machine-config-operator/blob/afb47c916680dd5870e48e5c9cf819f59e12ff4d/pkg/operator/render.go#L282-L294 [4]: https://github.com/openshift/machine-config-operator/blob/8fa0b7e8903226b3cfb76e6c6f49409cfc0dd0e7/pkg/operator/render.go#L282-L294 [5]: openshift/machine-config-operator#3084 [6]: openshift/machine-config-operator#2942 [7]: https://docs.openshift.com/container-platform/4.11/release_notes/ocp-4-11-release-notes.html#ocp-4-11-nutanix [8]: https://github.com/openshift/machine-config-operator/blob/afb47c916680dd5870e48e5c9cf819f59e12ff4d/templates/common/on-prem/files/keepalived.yaml#L155-L156 [9]: openshift/machine-config-operator@84d0bae#diff-c4a27bc4c14847dd581f495e992f67cf49b430644e8f113aabfa879de076564dL156 [10]: https://github.com/openshift/machine-config-operator/blob/afb47c916680dd5870e48e5c9cf819f59e12ff4d/pkg/operator/render.go#L249-L250

openshift-ci bot requested review from cgwalters and cheesesashimi February 3, 2022 17:04

thunderboltsid mentioned this pull request Feb 3, 2022

Nutanix platform #2852

Closed

yuqi-zhang reviewed Feb 9, 2022

View reviewed changes

pkg/operator/render.go Outdated Show resolved Hide resolved

thunderboltsid force-pushed the nutanix-platform branch 2 times, most recently from 6fbcb47 to 32abbf2 Compare February 14, 2022 17:13

thunderboltsid force-pushed the nutanix-platform branch from 32abbf2 to e270c7d Compare February 15, 2022 14:57

kikisdeliveryservice reviewed Feb 23, 2022

View reviewed changes

templates/master/01-master-kubelet/_base/files/kubelet.yaml Outdated Show resolved Hide resolved

kikisdeliveryservice reviewed Feb 23, 2022

View reviewed changes

go.mod Outdated Show resolved Hide resolved

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2022

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022

thunderboltsid force-pushed the nutanix-platform branch from abca3c7 to 4ef1ea6 Compare February 24, 2022 14:58

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022

kikisdeliveryservice removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2022

kikisdeliveryservice approved these changes Feb 24, 2022

View reviewed changes

kikisdeliveryservice removed request for cgwalters and cheesesashimi February 24, 2022 18:30

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022

openshift-merge-robot merged commit fce8f7c into openshift:master Mar 23, 2022

thunderboltsid mentioned this pull request Apr 1, 2022

Render Nutanix cloud provider as blank. #3051

Merged

Add Nutanix Platform to Machine Config Operator #2942

Add Nutanix Platform to Machine Config Operator #2942

Uh oh!

Conversation

thunderboltsid commented Feb 3, 2022

Uh oh!

kikisdeliveryservice commented Feb 4, 2022

Uh oh!

Uh oh!

thunderboltsid commented Feb 14, 2022

Uh oh!

thunderboltsid commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thunderboltsid commented Feb 23, 2022

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kikisdeliveryservice commented Feb 23, 2022

Uh oh!

thunderboltsid commented Feb 24, 2022

Uh oh!

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

Uh oh!

kikisdeliveryservice commented Feb 24, 2022

Uh oh!

thunderboltsid commented Feb 24, 2022

Uh oh!

thunderboltsid commented Feb 25, 2022

Uh oh!

thunderboltsid commented Feb 25, 2022

Uh oh!

adiantum commented Feb 25, 2022

Uh oh!

openshift-ci bot commented Feb 25, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

thunderboltsid commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 22, 2022

Uh oh!

kikisdeliveryservice commented Mar 22, 2022

Uh oh!

kikisdeliveryservice commented Mar 22, 2022

Uh oh!

kikisdeliveryservice commented Mar 22, 2022

Uh oh!

kikisdeliveryservice commented Mar 22, 2022

Uh oh!

openshift-bot commented Mar 23, 2022

Uh oh!

thunderboltsid commented Feb 14, 2022 •

edited

Loading

openshift-ci bot commented Mar 23, 2022 •

edited

Loading