Skip to content

Comments

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate#2580

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:ipv6-dual-stack-default
Jun 4, 2021
Merged

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate#2580
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:ipv6-dual-stack-default

Conversation

@danwinship
Copy link
Contributor

@danwinship danwinship commented May 19, 2021

It's on by default now, and setting it explicitly may result in an initial kubelet config that doesn't match the post-bootstrap one.

I think we're not hitting this in CI because we're still explicitly setting the feature gate there...

@danwinship
Don't explicitly set the IPv6DualStack feature gate
d51d70b 
It's on by default now, and setting it explicitly may result in an
initial kubelet config that doesn't match the post-bootstrap one.
@danwinship danwinship mentioned this pull request May 19, 2021
Merged
@danwinship
Copy link
Contributor Author

danwinship commented May 19, 2021

dev-scripts fix: openshift-metal3/dev-scripts#1242
Whichever one merges first will break dual-stack CI. There is no good way to avoid this.

@openshift-ci openshift-ci bot requested review from mrunalp and sjenning May 19, 2021 15:45
@dcbw
Copy link
Contributor

dcbw commented May 24, 2021

Looks like we're now failing metal dual-stack tests in ovnkube due to this:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ovn-kubernetes/551/pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack/1396842961500639232

fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: May 24 16:22:41.626: Some cluster operators are not ready: kube-apiserver (Upgradeable=False FeatureGates_RestrictedFeatureGates_IPv6DualStackNoUpgrade: FeatureGatesUpgradeable: "IPv6DualStackNoUpgrade" does not allow updates)

@dcbw
Copy link
Contributor

dcbw commented May 24, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2021
@dcbw dcbw mentioned this pull request May 24, 2021
Merged
@danwinship
Copy link
Contributor Author

danwinship commented May 24, 2021

/assign @mrunalp

@dcbw dcbw mentioned this pull request May 24, 2021
Merged
@aravindhp aravindhp mentioned this pull request May 24, 2021
Merged
@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented May 24, 2021

@danwinship is there a BZ for this? or will it wait?

@danwinship danwinship changed the title Don't explicitly set the IPv6DualStack feature gate Bug 1966602: Don't explicitly set the IPv6DualStack feature gate Jun 1, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2021

@danwinship: This pull request references Bugzilla bug 1966602, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

Details

In response to this:

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Jun 1, 2021

/assign @kikisdeliveryservice
oops, belatedly created the bz. This is needed for 4.8

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2021

@danwinship: This pull request references Bugzilla bug 1966602. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Jun 2, 2021

/reopen

@openshift-ci openshift-ci bot reopened this Jun 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@danwinship: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@danwinship: This pull request references Bugzilla bug 1966602, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

Details

In response to this:

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Jun 2, 2021

Bot got fooled by a comment in the dev-scripts PR. This is still needed

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 2, 2021

PTAL needs kubelet review

/assign @rphillips @sjenning @mrunalp

@danwinship
Copy link
Contributor Author

danwinship commented Jun 2, 2021

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@danwinship: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

@danwinship: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test cluster-bootimages
  • /test e2e-agnostic-upgrade
  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade
  • /test e2e-aws-workers-rhel7
  • /test e2e-azure
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test images
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-machine-config-operator-master-e2e-agnostic-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-workers-rhel7
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-config-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-e2e-aws
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test asdfasdf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor Author

danwinship commented Jun 2, 2021

/test e2e-metal-ipi-ovn-ipv6

@danwinship
Copy link
Contributor Author

danwinship commented Jun 2, 2021

PTAL needs kubelet review

/assign @rphillips @sjenning @mrunalp

It doesn't really need much kubelet review; all the patch does is remove a feature-gate which is now enabled by default anyway, reverting a0c44de.

(Without this patch, the bootstrap-time kubelet config won't match the runtime kubelet config now that we are no longer explicitly adding the feature gate to the runtime kubelet config, which will then mean that the node will fail to come up because it computes the wrong hash for its MachineConfig or whatever.)

@dcbw dcbw mentioned this pull request Jun 2, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dcbw, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 4, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e43ae96 into openshift:master Jun 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2021

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1966602 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1966602: Don't explicitly set the IPv6DualStack feature gate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam mentioned this pull request Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mrunalp mrunalp

@kikisdeliveryservice kikisdeliveryservice

@dcbw dcbw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danwinship @dcbw @kikisdeliveryservice @openshift-bot @mrunalp @openshift-merge-robot