Bug 1954773: adding cli flag for egressfirewall and removing CRD watcher#541
Conversation
on from watching CRDs Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
since moving egressFirewall to a cli flag there is no longer any need to watch CRDs Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
openshift-ci
bot
added
the
bugzilla/severity-high
|
@JacobTanenbaum: This pull request references Bugzilla bug 1954773, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/retest |
1 similar comment
|
/retest |
alexanderConstantinescu
left a comment
alexanderConstantinescu
left a comment
There was a problem hiding this comment.
This is more of a question, but why do we need commit: Remove node-side egress IP clients for this patch?
alexanderConstantinescu
left a comment
alexanderConstantinescu
left a comment
There was a problem hiding this comment.
This is more of a question, but why do we need commit:
Remove node-side egress IP clientsfor this patch?
Actually, never mind I can answer my own question: "because remove the CRD watch and related bits as they are no longer needed also touched pkg/node/ovn_test.go which means we need that commit to cleanly cherry-pick"
/lgtm
|
/restest |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, JacobTanenbaum, knobunc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JacobTanenbaum can you see if you can work out what is wrong with the Windows test? It seems to fail for everyone. Perhaps Jamo has some insight. |
|
/override ci/prow/e2e-aws-ovn-windows |
|
@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-ovn-windows DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
19 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-aws-ovn-windows There is another PR open to fix the test failures. |
|
@knobunc: Overrode contexts on behalf of knobunc: ci/prow/e2e-aws-ovn-windows, ci/prow/e2e-metal-ipi-ovn-dualstack DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@JacobTanenbaum: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@JacobTanenbaum: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1954773 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
cherry-picked three commits from upstream ovn-kube to apply cleanly and solve the problem
c37c866f78765dfe15fb06943ead64d0723fedba - change the egressFirewall to use a cli flag instead of dynamically turn
on from watching CRDs
2e870eb23259c71216bb56895d63394d84166527 - Remove node-side egress IP clients to help everything apply cleanly
f9af29bbd67dda81d7091c9651cef0cb3b1ff895 - remove the CRD watch and related bits as they are no longer needed
- What this PR does and why is it needed
- Special notes for reviewers
- How to verify it
- Description for the changelog