Bug 1962392: CARRY: fix missed learn for hybrid exgw#551
Bug 1962392: CARRY: fix missed learn for hybrid exgw#551openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
We are intentionally ignoring learn when something critical to the learn flow changes like pod ip, mac, exgw annotations. However, once we sync flows we should reset the pod to learn the flow on the next sync. However, we were only resetting pods for which we found flows already in OVS. This fixes that by restting ignoreLearn for all pods as long as we have a successful sync. Signed-off-by: Tim Rozet <trozet@redhat.com>
|
@trozet: This pull request references Bugzilla bug 1962392, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
|
@dcbw @fedepaol @dave-tucker PTAL |
openshift-ci
bot
added
the
approved
|
LGTM. |
|
/retest |
1 similar comment
|
/retest |
|
LGTM |
|
Looks like Federico's hold didn't work, so until he's OK: |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fedepaol and I reviewed and chatted on slack |
openshift-ci
bot
removed
the
do-not-merge/hold
|
One of the dual-stack failures is apparently openshift/machine-config-operator#2580 |
|
ovn-ipv6 failure is pulling images from:
/override ci/prow/e2e-aws-ovn-windows |
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-windows DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
ci/prow/4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade failing on capacity issues: |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
https://bugzilla.redhat.com/show_bug.cgi?id=1960758 openshift/machine-config-operator#2580 |
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-ipv6 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 1962392 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@trozet: new pull request created: #556 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
We are intentionally ignoring learn when something critical to the learn
flow changes like pod ip, mac, exgw annotations. However, once we sync
flows we should reset the pod to learn the flow on the next sync.
However, we were only resetting pods for which we found flows already in
OVS. This fixes that by restting ignoreLearn for all pods as long as we
have a successful sync.
Signed-off-by: Tim Rozet trozet@redhat.com