Skip to content

Bug 1948431: Bump openshift/api#2521

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
gnufied:bump-openshift-api
Apr 13, 2021
Merged

Bug 1948431: Bump openshift/api#2521
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
gnufied:bump-openshift-api

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Apr 9, 2021

This will allow us to get latest feature gates about CSI migration

Note: this is needed for CSI migration feature to work in OCP 4.8.
Goal of this PR is to apply --feature-gate=CSIMigrationAWS=true,CSIMigrationOpenStack=true to kubelet when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#880

This will allow us to get latest feature gates about CSI migration
@jsafrane
Copy link
Contributor

jsafrane commented Apr 9, 2021

Note: this is needed for CSI migration feature to work in OCP 4.8.
Goal of this PR is to apply --feature-gate=CSIMigrationAWS=true,CSIMigrationOpenStack=true to kubelet when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#880

@kikisdeliveryservice
Copy link
Contributor

Looks like this breaks the kubelet unit test TestFeatureGateDrift. You'll need to update =)

@jsafrane
Copy link
Contributor

/retest

@jsafrane
Copy link
Contributor

/retitle Bug 1948431: Bump openshift/api

@openshift-ci-robot openshift-ci-robot changed the title Bump openshift/api Bug 1948431: Bump openshift/api Apr 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 12, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: This pull request references Bugzilla bug 1948431, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

Details

In response to this:

Bug 1948431: Bump openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 12, 2021
@jsafrane
Copy link
Contributor

@kikisdeliveryservice added BZ and fixed unit tests. PTAL.

@gnufied
Copy link
Member Author

gnufied commented Apr 12, 2021

/retest

@kikisdeliveryservice
Copy link
Contributor

@rphillips can you PTAL since this touches some kubelet templates?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@kikisdeliveryservice
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Copy link
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, kikisdeliveryservice, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f7b24ec into openshift:master Apr 13, 2021
@openshift-ci-robot
Copy link
Contributor

@gnufied: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1948431 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1948431: Bump openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants