Bug 1948431: Bump openshift/api#2521
Conversation
This will allow us to get latest feature gates about CSI migration
|
Note: this is needed for CSI migration feature to work in OCP 4.8. |
|
Looks like this breaks the kubelet unit test TestFeatureGateDrift. You'll need to update =) |
|
/retest |
|
/retitle Bug 1948431: Bump openshift/api |
|
@gnufied: This pull request references Bugzilla bug 1948431, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kikisdeliveryservice added BZ and fixed unit tests. PTAL. |
|
/retest |
|
@rphillips can you PTAL since this touches some kubelet templates? |
|
/lgtm |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, kikisdeliveryservice, rphillips, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@gnufied: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1948431 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will allow us to get latest feature gates about CSI migration
Note: this is needed for CSI migration feature to work in OCP 4.8.
Goal of this PR is to apply --feature-gate=CSIMigrationAWS=true,CSIMigrationOpenStack=true to kubelet when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#880