Bug 1937594: Respect status.Migration in network.config when exsits by pliurh · Pull Request #2518 · openshift/machine-config-operator

pliurh · 2021-04-09T07:33:25Z

When status.Migration is set in network.config. MCO shall render
the node according to the target networkType.

openshift-ci-robot · 2021-04-09T07:33:31Z

@pliurh: This pull request references Bugzilla bug 1937594, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (huirwang@redhat.com), skipping review request.

Details

In response to this:

Bug 1937594: Respect status.Migration in network.config when exsits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pliurh · 2021-04-09T07:33:41Z

/cc @danwinship

openshift-ci-robot · 2021-04-09T11:26:49Z

@pliurh: This pull request references Bugzilla bug 1937594. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1937594: Respect status.Migration in network.config when exsits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-12T03:48:48Z

@pliurh: This pull request references Bugzilla bug 1937594, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (huirwang@redhat.com), skipping review request.

Details

In response to this:

Bug 1937594: Respect status.Migration in network.config when exsits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pliurh · 2021-04-12T03:50:28Z

This PR needs to rebase after MCO adopt the latest openshift/api. #2521

kikisdeliveryservice · 2021-04-12T16:15:50Z

adding a hold until #2521 merges

/hold

kikisdeliveryservice · 2021-04-12T16:18:11Z

/assign @danwinship

openshift-ci-robot · 2021-04-13T15:22:37Z

@pliurh: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When status.Migration is set in network.config. MCO shall render the node according to the target networkType.

sinnykumari · 2021-04-14T08:32:21Z

#2521 has been merged and this PR needs rebase.

danwinship · 2021-04-14T12:35:04Z

/lgtm
it doesn't need a rebase because the bot does that when it merges anyway

pliurh · 2021-04-15T02:28:47Z

@kikisdeliveryservice Could you unhold this PR?

pliurh · 2021-04-15T02:29:00Z

/retest

sinnykumari · 2021-04-15T08:11:50Z

/hold cancel

sinnykumari

LGTM
have removed hold since dependent PR has been merged and PR has been rebased

openshift-ci-robot · 2021-04-15T08:14:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, pliurh, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pliurh · 2021-04-15T12:01:35Z

/retest

openshift-bot · 2021-04-15T14:22:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T19:11:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T19:23:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T22:35:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T23:11:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T23:35:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-15T23:47:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T00:11:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-16T00:35:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-04-16T02:55:36Z

@pliurh: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-vsphere-upgrade	`338efd0`	link	`/test e2e-vsphere-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-04-16T04:35:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-16T06:36:16Z

@pliurh: Some pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1057

The following pull requests linked via external trackers have not merged:

openshift/cluster-network-operator#763 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1937594 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1937594: Respect status.Migration in network.config when exsits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 9, 2021

openshift-ci-robot requested review from danwinship, kikisdeliveryservice and sinnykumari April 9, 2021 07:33

pliurh mentioned this pull request Apr 9, 2021

Bug 1937594: Split SDN migration into 2 phase openshift/cluster-network-operator#763

Merged

pliurh closed this Apr 9, 2021

pliurh force-pushed the migration branch from bef19bf to 9c6c2bf Compare April 9, 2021 11:26

pliurh reopened this Apr 12, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2021

openshift-ci-robot assigned danwinship Apr 12, 2021

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2021

Respect status.Migration in network.config when exsits

338efd0

When status.Migration is set in network.config. MCO shall render the node according to the target networkType.

pliurh force-pushed the migration branch from bba050e to 338efd0 Compare April 14, 2021 02:11

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2021

sinnykumari approved these changes Apr 15, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021

openshift-merge-robot merged commit 19a3615 into openshift:master Apr 16, 2021

openshift-ci-robot mentioned this pull request Apr 20, 2021

Bug 1937594: Update the codegen with the latest API openshift/cluster-network-operator#1063

Merged

Conversation

pliurh commented Apr 9, 2021

Uh oh!

openshift-ci-robot commented Apr 9, 2021

Uh oh!

pliurh commented Apr 9, 2021

Uh oh!

openshift-ci-robot commented Apr 9, 2021

Uh oh!

openshift-ci-robot commented Apr 12, 2021

Uh oh!

pliurh commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kikisdeliveryservice commented Apr 12, 2021

Uh oh!

kikisdeliveryservice commented Apr 12, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

sinnykumari commented Apr 14, 2021

Uh oh!

danwinship commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pliurh commented Apr 15, 2021

Uh oh!

pliurh commented Apr 15, 2021

Uh oh!

sinnykumari commented Apr 15, 2021

Uh oh!

sinnykumari left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 15, 2021

Uh oh!

pliurh commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 15, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-ci bot commented Apr 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 16, 2021

Uh oh!

openshift-ci-robot commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pliurh commented Apr 12, 2021 •

edited

Loading

danwinship commented Apr 14, 2021 •

edited

Loading

openshift-ci bot commented Apr 16, 2021 •

edited

Loading