Skip to content

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates#1098

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
huffmanca:bump-api
Apr 13, 2021
Merged

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates#1098
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
huffmanca:bump-api

Conversation

@huffmanca
Copy link
Copy Markdown
Contributor

@huffmanca huffmanca commented Apr 9, 2021

The CSI Migration tech preview feature is included in openshift/api, and I'm bumping the version here so that the FeatureGate can be propagated correctly.

Goal of this PR is to apply --feature-gate=CSIMigrationAWS=true,CSIMigrationOpenStack=true to kube-apiserver when TechPreviewNoUpgrade featureSet is enabled, which was introduced in openshift/api#880 .

@huffmanca huffmanca changed the title Bump openshift/api Bump openshift/api to get the necessary CSIMigration feature gates Apr 9, 2021
@jsafrane
Copy link
Copy Markdown
Contributor

/retitle Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

@openshift-ci-robot openshift-ci-robot changed the title Bump openshift/api to get the necessary CSIMigration feature gates Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates Apr 12, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@huffmanca: This pull request references Bugzilla bug 1948431, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (piqin@redhat.com), skipping review request.

Details

In response to this:

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 12, 2021

/retest
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2021
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@jsafrane
Copy link
Copy Markdown
Contributor

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d406726 into openshift:master Apr 13, 2021
@openshift-ci-robot
Copy link
Copy Markdown

@huffmanca: All pull requests linked via external trackers have merged:

Bugzilla bug 1948431 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1948431: Bump openshift/api to get the necessary CSIMigration feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto bertinatto mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants