Bug 1895099: Fix VSphere UPI not populating PlatformStatus #2207
Conversation
openshift-ci-robot
added
the
bugzilla/severity-high
|
@bcrochet: This pull request references Bugzilla bug 1895099, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
cc @jcpowermac |
|
Not sure if these are setup: |
|
/test e2e-vsphere |
There was a problem hiding this comment.
don't we need to replace this with the simpler conditional used in other templates? {{ if (onPremPlatformAPIServerInternalIP .) -}}
There was a problem hiding this comment.
There is no reference to the PlatformStatus in that file. Are you saying you don't want it at all?
|
https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-mdns-hostname.yaml also needs to be checked for |
The VSphere UPI install does not fully populate PlatformStatus. When we deduped the templates, we didn't account for this being nil. This should render these templates empty when that PlatformStatus is nil.
|
/test e2e-vsphere-upi |
|
/test e2e-vsphere |
|
/test e2e-vsphere |
|
CI is consistently failing with /lgtm |
|
/retest |
|
/test e2e-vsphere-upi |
|
/test e2e-vsphere |
|
MCO is still configured for template vs. multistep at least for UPI. |
|
/test e2e-vsphere-upi |
|
This may not pass until #2209 is merged. It might need a rebase after. |
|
@bcrochet looking at job results the installation succeeded the tests failed. I think this could move forward as-is. @patrickdillon wdyt? |
If you're ok with the order, it doesn't matter to me. This patch would probably allow #2209 to pass, or vice versa. This one is probably failing because of the problem fixed in the #2209. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
16 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Any chance we can get an override for gcp-op? This PR is needed for vSphere UPI to install and CI to pass. |
|
Waiting for some other CI troubles to get resolved (namely AWS which is blocking the GCP fix). Will override by EoD if those are still blocking |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Ok given the AWS still slowly recovering, and the fact that this has passed all the other tests in the past + it should not affect cloud platforms, I will override this. /override ci/prow/e2e-gcp-op |
|
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bcrochet: All pull requests linked via external trackers have merged: Bugzilla bug 1895099 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
The VSphere UPI install does not fully populate PlatformStatus. When we deduped
the templates, we didn't account for this being nil. This should render these
templates empty when that PlatformStatus is nil.
- What I did
- How to verify it
- Description for the changelog