Skip to content

Conversation

@bcrochet
Copy link
Member

@bcrochet bcrochet commented Nov 9, 2020

An on-prem template wasn't moved correctly, and an OpenStack template was moved when it shouldn't have been.

- What I did

- How to verify it

- Description for the changelog

@bcrochet
Copy link
Member Author

bcrochet commented Nov 9, 2020

/test e2e-ovirt
/test e2e-vsphere
/test e2e-vsphere-upi
/test e2e-openstack

An on-prem template wasn't moved correctly, and an OpenStack template
was moved when it shouldn't have been.
@bcrochet bcrochet changed the title Add the kni-tmpfiles to on-prem Move some deduped templates back to where they belong Nov 9, 2020
@bcrochet
Copy link
Member Author

bcrochet commented Nov 9, 2020

/test e2e-ovirt
/test e2e-vsphere
/test e2e-vsphere-upi
/test e2e-openstack

@Gal-Zaidman
Copy link

/test e2e-vsphere-upi

@Gal-Zaidman
Copy link

/test e2e-agnostic-upgrade

@Gal-Zaidman
Copy link

/test e2e-vsphere

@Gal-Zaidman
Copy link

/retest

1 similar comment
@bcrochet
Copy link
Member Author

/retest

@Gal-Zaidman
Copy link

/test e2e-ovirt

1 similar comment
@Gal-Zaidman
Copy link

/test e2e-ovirt

@bcrochet
Copy link
Member Author

/test e2e-openstack

@derekhiggins
Copy link

/test e2e-metal-ipi-ovn-dualstack

1 similar comment
@stbenjam
Copy link
Member

/test e2e-metal-ipi-ovn-dualstack

@bcrochet
Copy link
Member Author

/retest

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@iamemilio
Copy link

/test e2e-openstack

@bcrochet
Copy link
Member Author

/retest

@kikisdeliveryservice
Copy link
Contributor

This is kni/openstack, I'd like to see owners from both lgtm before approving

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2020
@stbenjam
Copy link
Member

/lgtm

@cybertron
Copy link
Member

/lgtm

So that's why afterburn started showing up in my failed units lately. :-)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bcrochet
Copy link
Member Author

@yuqi-zhang On this one, it is safe to skip e2e-metal-ipi-ovn-dualstack. It was added as a test for an unrelated issue. vsphere-upi should pass once 2207 is merged.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yuqi-zhang
Copy link
Contributor

Given the AWS still slowly recovering, and the fact that this has passed all the other tests in the past + it should not affect cloud platforms, I will override e2e-gcp-op on this.

/override ci/prow/e2e-gcp-op

@openshift-ci-robot
Copy link
Contributor

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op

Details

In response to this:

Given the AWS still slowly recovering, and the fact that this has passed all the other tests in the past + it should not affect cloud platforms, I will override e2e-gcp-op on this.

/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@runcom
Copy link
Member

runcom commented Nov 18, 2020

follow up from #2209 (comment)

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-metal-ipi-ovn-dualstack

@openshift-ci-robot
Copy link
Contributor

@runcom: Overrode contexts on behalf of runcom: ci/prow/e2e-gcp-op, ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

follow up from #2209 (comment)

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-metal-ipi-ovn-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 18, 2020

@bcrochet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack d407e16 link /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b990721 into openshift:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.