Bug 1895099: Create empty vSphere infra PlatformStatus in UPI

[patrickdillon]

This creates an empty infrastructure.Status.PlatformStatus.VSphere object during UPI installs. Prior to this change, the object has been nil during UPI installs. The object is optional, but a recent change to MCO templating0 has a dependency on the object.

cc @jcpowermac

[openshift-ci-robot]

@patrickdillon: This pull request references Bugzilla bug 1895099, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1895099: Create empty vSphere infra PlatformStatus in UPI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

/test e2e-vsphere
/test e2e-vsphere-upi

[openshift-ci-robot]

@patrickdillon: This pull request references Bugzilla bug 1895099, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1895099: Create empty vSphere infra PlatformStatus in UPI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcpowermac]

Makes sense to me. I will let tests run and see if upi is green.

[patrickdillon]

@jcpowermac righly pointed out (on slack) this will not fix upgrades, not sure if this PR has merit on its own, i will look at an analogue mco fix

[patrickdillon]

/hold

Hm it looks like these changes might just result in a mangled config file where the IP addresses are missing but the rest of the config file is present: https://github.com/openshift/machine-config-operator/blob/master/templates/common/on-prem/files/NetworkManager-resolv-prepender.yaml

Before the mco changes, we wouldn't populate any of the config file: https://github.com/openshift/machine-config-operator/pull/2079/files#diff-88b9eeb5fb253707d42dfa34ac2143dda76d949209de64c032a8cd11a0d97c29

[openshift-merge-robot]

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-crc	10caec1	link	/test e2e-crc
ci/prow/e2e-ovirt	10caec1	link	/test e2e-ovirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

/close
in favor of openshift/machine-config-operator#2207

[openshift-ci-robot]

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of openshift/machine-config-operator#2207

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.