fix upgrade path for static pod manager #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alaypatel07 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
alaypatel07
force-pushed
the
upgrade
branch
2 times, most recently
from
d2b666d to
7343d6c
Compare
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
openshift-ci-robot
added
size/M
Contributor
Author
|
FTR this will only upgrade from 4.3 to 4.4. Upgrades from 4.4 (old CEO) to 4.4(static pod manager CEO) will break |
|
@alaypatel07: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/close |
jaypoulz
added a commit
to jaypoulz/cluster-etcd-operator
that referenced
this pull request
Sep 18, 2025
… setup job - Setup job now sets Available condition only when ExternalEtcd isn't enabled yet (includes test) - Fixed jobcontroller & test setup to handle variable operator status conditions - Added test coverage for updated expectations for job controller condition transitions (Progressing, Degraded, Available) Depends on openshift#148
jaypoulz
added a commit
to jaypoulz/cluster-etcd-operator
that referenced
this pull request
Sep 18, 2025
… setup job - Setup job now sets Available condition only when ExternalEtcd isn't enabled yet (includes test) - Fixed jobcontroller & test setup to handle variable operator status conditions - Added test coverage for updated expectations for job controller condition transitions (Progressing, Degraded, Available) Depends on openshift#148
jaypoulz
added a commit
to jaypoulz/cluster-etcd-operator
that referenced
this pull request
Sep 18, 2025
… setup job - Setup job now sets Available condition only when ExternalEtcd isn't enabled yet (includes test) - Fixed jobcontroller & test setup to handle variable operator status conditions - Added test coverage for updated expectations for job controller condition transitions (Progressing, Degraded, Available) Depends on openshift#148
jaypoulz
added a commit
to jaypoulz/cluster-etcd-operator
that referenced
this pull request
Sep 30, 2025
… setup job - Setup job now sets Available condition only when ExternalEtcd hasn't transitioned yet - Fixed jobcontroller & test setup to handle variable operator status conditions - Added test coverage for updated expectations for job controller condition transitions (Progressing, Degraded, Available) - Add HasExternalEtcdCompletedTransition to track when external etcd transition completes - Fixed HasAutomaticQuorumRecovery to check transition completion (not just readiness) - Added tests for external etcd transition lifecycle Depends on openshift#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a commit make sure the etcd pods rendered by static
pod manager sleeps until the MCO pods is not evicted. Since,
CEO is the first to get upgraded and MCO is the last, we need to
wait in the interim.
This also updates the readiness probe. The static pod controllers
in CEO will only progress if etcd pods are ready. With certs now
available in the pods, we can use the
etcdctlto check the healthof local etcd member.
This will break the installs until openshift/machine-config-operator#1465
does not land