add support for openshift actuator #34
Conversation
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Superseeds #32 |
|
|
||
| glog.Info("Trying to deploy MachineSet object") | ||
| _, err = v1alphaClient.MachineSets("test").Create(machineSet) | ||
| _, err = v1alphaClient.MachineSets("default").Create(machineSet) |
There was a problem hiding this comment.
default still better than test. Though, is this the final namespace? I would rather make the namespace configurable. Either via configmap or via mao --namespace or similar option.
There was a problem hiding this comment.
thanks. Yes, there's separate tickets for addressing dedicated namespaces and service accounts.
| - filters: | ||
| - name: "tag:Name" | ||
| values: | ||
| - {{.ClusterName}}_worker_sg |
There was a problem hiding this comment.
This is probably fine for now, but just a thought: If we're going to select security groups this way, we may want to also filter by cluster ID if that's available.
| - {{.ClusterName}}-worker-{{.AvailabilityZone}} | ||
| publicIp: true | ||
| iamInstanceProfile: | ||
| id: {{.ClusterName}}-master-profile |
There was a problem hiding this comment.
Should this be -worker-profile?
We've had this since 04253cb (add support for openshift actuator, 2018-08-29, openshift#34), but we don't need direct access to the workers. Folks who do need to SSH into them, or whatever, should be able to access them via the masters.
Requeue machine every 20s until running.
Fix name of the credentials key
OCPCLOUD-1804: Port to ginkgo v2
5 participants
This allows to integrate the openshift actuator with mao and the installer: