add support for filters on sg and subnet #35
Conversation
openshift-ci-robot
added
size/L
|
Follow up:
|
examples/machine-with-filters.yaml
Outdated
There was a problem hiding this comment.
Are filters fixed to tags or can you use non-tag names to specify filters?
There was a problem hiding this comment.
you can specify aws attributes, not necessarily tags, hence we don't wanna harcode it in code
There was a problem hiding this comment.
ec2Filters is not used anywhere else so it's fine to Filters: buildEc2Filters(g.Filters)
There was a problem hiding this comment.
ec2Filters is not used anywhere else so it's fine to Filters: buildEc2Filters(subnet.Filters)
There was a problem hiding this comment.
buildEc2Filters looks good, can you use it in the AMI selection part as well? Lines 143-157.
There was a problem hiding this comment.
this matches current installer behaviour
There was a problem hiding this comment.
Looks like you could just return here on the first one and stop iterating the loop if we're just looking to return the first.
Should we warn if multiple results were returned?
There was a problem hiding this comment.
thanks! made the function able to return multiple ids, then upper level function decideds what to do and warns
|
/test e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🐛 Fix renovate and update konflux ref
5 participants
This allows to integrate the openshift actuator with mao and the installer: