machines/aws/worker.machineset: Drop pubicIp #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had this since 04253cb (add support for openshift actuator, 2018-08-29, openshift#34), but we don't need direct access to the workers. Folks who do need to SSH into them, or whatever, should be able to access them via the masters.
openshift-ci-robot
added
the
size/XS
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ingvagabund
pushed a commit
to ingvagabund/machine-api-operator
that referenced
this pull request
Jul 11, 2019
…tus-reconciliation Stop nonstop status reconciliation
germanparente
pushed a commit
to germanparente/machine-api-operator
that referenced
this pull request
Sep 23, 2025
Bug 1809345: Add the machine's name as a known NodeInternalDNS
germanparente
pushed a commit
to germanparente/machine-api-operator
that referenced
this pull request
Sep 23, 2025
CFE-1106: Remove featureGate checks for processing userLabels and userTags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had this since 04253cb (#34), but we don't need direct access to the workers. Folks who do need to SSH into them, or whatever, should be able to access them via the masters.
Or maybe I'm just missing something, and this is actually important?