scope down permissions to namespace #315
Conversation
openshift-ci-robot
added
the
size/L
enxebre
force-pushed
the
role
branch
2 times, most recently
from
04fbeee to
1b06b3e
Compare
|
/retest |
1 similar comment
|
/retest |
enxebre
force-pushed
the
role
branch
2 times, most recently
from
8229d42 to
40129e1
Compare
|
/lgtm |
enxebre
force-pushed
the
role
branch
2 times, most recently
from
d00d8ff to
691fac8
Compare
|
/test integration |
2 similar comments
|
/test integration |
|
/test integration |
pkg/operator/sync.go
Outdated
| args := []string{ | ||
| "--logtostderr=true", | ||
| "--v=3", | ||
| "--namespace=openshift-machine-api", |
There was a problem hiding this comment.
This needs to be parametrized. ci/jenkins/integration expects all machines to live under kube-system, not openshift-machine-api. Otherwise, no machine can be found by the machine-controller and no machine is created, no machine status updated, no machine linked with a node. Thus the reason why the CI is failing.
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
With openshift/machine-api-operator#315 the Machine API Operator doesn't have access to the `kube-system` namespace anymore. We now need to issue a CredentialsRequest in MAO and retrieve it from the `openshift-machine-api` namespace here. Needs openshift/machine-api-operator#324
6 participants
Scope down permissions to openshift-machine-api namespace
Needs - openshift/cluster-api-provider-aws#209
Needs #316