Skip to content

openstack: Retrieve namespaced credentials #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 14, 2019
Merged

openstack: Retrieve namespaced credentials #1849

openshift-merge-robot merged 1 commit into from
Jun 14, 2019

Conversation

@mandre
Copy link
Member

@mandre mandre commented Jun 13, 2019

With openshift/machine-api-operator#315 the Machine API Operator
doesn't have access to the kube-system namespace anymore.

We now need to issue a CredentialsRequest in MAO and retrieve it from
the openshift-machine-api namespace here.

Needs openshift/machine-api-operator#324

@mandre
openstack: Retrieve namespaced credentials
e17a5a1 
With openshift/machine-api-operator#315 the Machine API Operator
doesn't have access to the `kube-system` namespace anymore.

We now need to issue a CredentialsRequest in MAO and retrieve it from
the `openshift-machine-api` namespace here.

Needs openshift/machine-api-operator#324
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2019
@mandre
Copy link
Member Author

mandre commented Jun 13, 2019

/cc @trown @tomassedovic

Depends on openshift/machine-api-operator#324 and openshift/cluster-api-provider-openstack#46

@mandre
Copy link
Member Author

mandre commented Jun 14, 2019

We expect e2e-openstack to fail until openshift/cluster-api-provider-openstack#47 merges.

@trown
Copy link

trown commented Jun 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@tomassedovic
Copy link
Contributor

tomassedovic commented Jun 14, 2019

/lgtm

openshift/machine-api-operator#324 is merged now and with it and openshift/cluster-api-provider-openstack#46 the workers come up properly.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, tomassedovic, trown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tomassedovic tomassedovic mentioned this pull request Jun 14, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0df30d6 into openshift:master Jun 14, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 14, 2019

@mandre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 e17a5a1 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandre mandre deleted the openstack-creds branch September 17, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@jstuever jstuever Awaiting requested review from jstuever

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

@trown trown Awaiting requested review from trown

Assignees

@tomassedovic tomassedovic

@trown trown

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mandre @trown @openshift-bot @tomassedovic @openshift-ci-robot @openshift-merge-robot