Skip to content

Reduce machine controller watched scope to namespace #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
May 15, 2019
Merged

Reduce machine controller watched scope to namespace #209

openshift-merge-robot merged 2 commits into from
May 15, 2019

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented May 14, 2019 •
edited
Loading

machines upstream have historically been namespaced for remote cluster management purposes.
We want to lock everything down to the same namespace openshift-machine-api so permissions can be more granular than clusterRole

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 14, 2019
@enxebre
Copy link
Member Author

enxebre commented May 14, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2019
@enxebre enxebre removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2019 •
edited
Loading

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 387a726 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vikaschoudhary16
Copy link

vikaschoudhary16 commented May 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2019
@enxebre enxebre changed the title Reduce machine controller scope to openshift-machine-api namespace Reduce machine controller watched scope to namespace May 15, 2019
@enxebre enxebre mentioned this pull request May 15, 2019
Merged
@enxebre
Copy link
Member Author

enxebre commented May 15, 2019

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0e9a428 into openshift:master May 15, 2019
michaelgugino pushed a commit to mgugino-upstream-stage/cluster-api-provider-aws that referenced this pull request Feb 12, 2020
@chuckha @k8s-ci-robot
Use the latest release of cluster-api (openshift#209)
798d4dd 
Signed-off-by: Chuck Ha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@vikaschoudhary16 vikaschoudhary16

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enxebre @openshift-ci-robot @vikaschoudhary16 @openshift-merge-robot