[CNF-5643] add capability annotation #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
qJkee
force-pushed
the
CNF-5643-make-operator-optional
branch
from
e19f0c3 to
71a03f8
Compare
qJkee
force-pushed
the
CNF-5643-make-operator-optional
branch
from
2d026ac to
b11af69
Compare
Contributor
|
Why is this still marked WIP? Can we please add an appropriate PR description to it as well and look into any genuine test failures |
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
qJkee
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
qJkee
force-pushed
the
CNF-5643-make-operator-optional
branch
from
27d5d60 to
f7bec90
Compare
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
wking
added a commit
to wking/machine-api-operator
that referenced
this pull request
Jul 25, 2023
Since these manifests took effect in af2f3bd (add cvo ha annotations to tombstones, 2021-07-29, openshift#893, OpenShift 4.9), the only change has been d3a5a0e (add capability annotation, 2023-02-14, openshift#1119). We can remove these deletion references now, because a 4.8 cluster that might have included these resources should have completed an update to 4.9 which would have removed them. And if that failed, they should have completed an update to one of the later 4.y and removed the resources. By removing the resource, we save the cluster-version operator some time checking to ensure deletion, and only expose ourselves to leaking the resources on clusters that updated from 4.8 through to 4.14 without ever having completed an update before reaching 4.14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capability annotation to the manifests to make operator optional