Skip to content

[CNF-5643] bump api version to add new capability #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qJkee wants to merge 3 commits into from
Closed

[CNF-5643] bump api version to add new capability #937

qJkee wants to merge 3 commits into from

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented May 18, 2023

Upgrade openshift/api to the latest version with new capability

qJkee added 2 commits May 18, 2023 10:03
@qJkee
vendor: upgrade openshift/api
6381540 
go get github.com/openshift/api@f36cfb9a990998106c5ebaa4fad0c7ff1264a2f5
go mod tidy
go mod vendor
git add -A go.* vendor
@qJkee
update tests with new capabilities
20d0ffe 
update tests with new capabilities brought by
new version of openshift/api package
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qJkee
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qJkee
Copy link
Contributor Author

qJkee commented May 19, 2023

/retest

@qJkee
Copy link
Contributor Author

qJkee commented May 21, 2023

/test lint

@qJkee
Copy link
Contributor Author

qJkee commented May 22, 2023

New linter version detects more code issues.
But the warning related to deprecated wait.PollImmediate is blocked by kubernetes/kubernetes#116712

@qJkee qJkee force-pushed the CNF-5643-bump-api branch from f711ac6 to ef7fb50 Compare May 22, 2023 17:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change ef7fb50 link true /test e2e-agnostic-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

petr-muller commented May 23, 2023

/cc

@openshift-ci openshift-ci bot requested a review from petr-muller May 23, 2023 12:50
wking
wking reviewed May 23, 2023
View reviewed changes
pkg/autoupdate/autoupdate.go
}

//nolint:errcheck
cvInformer.Informer().AddEventHandler(ctrl.eventHandler())
Copy link
Member

@wking wking May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fdf3419 (#934), I'm plumbing through error checks for these calls. Some of the other commits in that in-flight pull request address other Go-lint/modernization issues too, if you want to pick them up here.

@wking
Copy link
Member

wking commented May 23, 2023

There seems to be a bunch of failing CI in openshift/machine-api-operator#1119. Have you completed step 3 in the recommended new-capability workflow?

@qJkee
Copy link
Contributor Author

qJkee commented May 23, 2023

@wking
machine-api capability is mainly targeted for SNO deployments. Is expected that regular 3 node cluster will fail without machine-api. When this PR merges in, it should be a green pass

@qJkee qJkee closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qJkee @petr-muller @wking