Skip to content

[CNF-5643] add machine-api capability #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 18, 2023
Merged

[CNF-5643] add machine-api capability #1449

openshift-merge-robot merged 1 commit into from
May 18, 2023

Conversation

@qJkee
Copy link
Contributor

@qJkee qJkee commented Apr 26, 2023 •
edited
Loading

This PR add machine-api capability which
disables the following operators

  • machine-api-operator
  • cluster-autoscaler-operator
  • cluster-control-plane-machine-set-operator
    This capability is responsible for machines configuration
    and heavily targeted for SNO clusters.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

Hello @qJkee! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2023
@openshift-ci openshift-ci bot requested review from knobunc and soltysh April 26, 2023 10:02
@qJkee
Copy link
Contributor Author

qJkee commented Apr 26, 2023

/assign @JoelSpeed

@qJkee qJkee force-pushed the CNF-5643-add-machine-api-cap branch from a8604e4 to 283d258 Compare April 28, 2023 10:21
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 2, 2023

Code changes I think are ok here, would like us to get QE approval on the MAPI parts before merging so we've had a complete E2E test, i think that's imminent anyway

@qJkee qJkee changed the title [WIP][CNF-5643] add machine-api capability [CNF-5643] add machine-api capability May 16, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 16, 2023

Please make sure to add an appropriate PR description for the PR, do we need this for other CI to pass? Else, can we get a green signal on the MAO PR before we merged this?

@qJkee qJkee force-pushed the CNF-5643-add-machine-api-cap branch from 283d258 to c1bcde1 Compare May 17, 2023 17:03
@qJkee
Copy link
Contributor Author

qJkee commented May 17, 2023

@JoelSpeed
Fixed!

To get green passes on other PRs we need to merge API to CVO and installer first

@qJkee qJkee mentioned this pull request May 17, 2023
Merged
@qJkee
[CNF-5643]add machine-api capability
3778e7a 
This PR add machine-api capability which
disables the following operators
- machine-api-operator
- cluster-autoscaler-operator
- cluster-control-plane-machine-set-operator
This capability is responsible for machines configuration
and heavily targeted for SNO clusters.
@qJkee qJkee force-pushed the CNF-5643-add-machine-api-cap branch from c1bcde1 to 3778e7a Compare May 17, 2023 18:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 17, 2023

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit f36cfb9 into openshift:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qJkee @JoelSpeed @openshift-merge-robot