OCPBUGS-1871: Fix machine not going failed with invalid vmsize #36

RadekManak · 2022-10-07T14:42:08Z

This error needs to be InvalidMachineConfiguration, because machine goes failed only if it finds error of that type.

openshift-ci-robot · 2022-10-07T14:42:12Z

@RadekManak: This pull request references Jira Issue OCPBUGS-1871, which is invalid:

expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This error needs to be InvalidMachineConfiguration, because machine goes failed only if it finds error of that type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RadekManak · 2022-10-07T14:44:29Z

/hold Might not always be invalid

RadekManak · 2022-10-07T15:00:47Z

/unhold
We treat failure to send request to create machine as invalid machine configuration, so I think failure to retrieve instance type information can be invalid machine configuration as well.

JoelSpeed · 2022-10-10T08:57:48Z

pkg/cloud/azure/actuators/machine/reconciler.go

 		skuI, err := s.resourcesSkus.Get(ctx, skuSpec)
 		if err != nil {
-			return fmt.Errorf("failed to find sku %s", s.scope.MachineConfig.VMSize)
+			return machinecontroller.InvalidMachineConfiguration("failed to fetch instance type information from azure: %w", err)


Could this be a transient error? What machine configuration leads into this? Is there a way to be more precise here, eg, if it returns a not found error vs something else?

JoelSpeed · 2022-10-13T12:11:37Z

/approve
/lgtm

Thanks for updating

openshift-ci · 2022-10-13T12:12:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed · 2022-10-14T08:41:57Z

/jira refresh

openshift-ci-robot · 2022-10-14T08:42:00Z

@JoelSpeed: This pull request references Jira Issue OCPBUGS-1871, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2022-10-14T08:42:54Z

/jira refresh

openshift-ci-robot · 2022-10-14T08:43:00Z

@JoelSpeed: This pull request references Jira Issue OCPBUGS-1871, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huali9

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2022-10-14T08:44:32Z

/override ci/prow/e2e-azure-operator

The failure in the e2e is resolved by openshift/machine-api-operator#1076 and the tests that didn't run are autoscaler related, confident this change isn't going to break those

openshift-ci · 2022-10-14T08:45:43Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-operator

Details

In response to this:

/override ci/prow/e2e-azure-operator

The failure in the e2e is resolved by openshift/machine-api-operator#1076 and the tests that didn't run are autoscaler related, confident this change isn't going to break those

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed · 2022-10-14T08:45:49Z

/hold

@RadekManak There are some comments in the bug about the message having changed, how would you like to resolve that?

JoelSpeed · 2022-10-14T13:38:35Z

/lgtm
/retest-required

openshift-ci-robot · 2022-10-14T17:12:42Z

/retest-required

Remaining retests: 0 against base HEAD e62926d and 2 for PR HEAD 6da451e in total

JoelSpeed · 2022-10-17T08:17:00Z

/retest-required

JoelSpeed · 2022-10-17T11:53:30Z

/retest-required

JoelSpeed · 2022-10-18T08:14:17Z

/retest-required

JoelSpeed · 2022-10-18T11:38:40Z

/hold

This failed QE, seems we need to do a similar change in another part of the code when we haven't got accelerated networking enabled

RadekManak · 2022-10-18T14:48:56Z

Changed it to use the same error handling in all three places that call the resourceskus. Get function.
/unhold

RadekManak · 2022-10-18T14:50:32Z

/retest
Did the tests get stuck?

huali9 · 2022-10-19T04:06:14Z

/label qe-approved

JoelSpeed · 2022-10-19T07:40:21Z

/lgtm
/retest-required

openshift-ci-robot · 2022-10-19T11:06:26Z

/retest-required

Remaining retests: 0 against base HEAD 96739ba and 2 for PR HEAD 7fd0017 in total

JoelSpeed · 2022-10-19T16:16:04Z

/retest-required

JoelSpeed · 2022-10-20T09:08:21Z

/retest-required

JoelSpeed · 2022-10-20T12:04:48Z

/retest-required

JoelSpeed · 2022-10-20T12:07:48Z

/retest-required

JoelSpeed · 2022-10-21T08:14:57Z

/retest-required

JoelSpeed · 2022-10-21T12:51:35Z

/override ci/prow/e2e-azure-operator

This failed on the penultimate test which we are working on fixing, this is a known issue. I don't believe this PR is causing any problems. All the previous tests have passed and 2 of the 4 autoscaler tests passed indicating the autoscaler is also functional

openshift-ci · 2022-10-21T12:52:56Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-azure-operator

Details

In response to this:

/override ci/prow/e2e-azure-operator

This failed on the penultimate test which we are working on fixing, this is a known issue. I don't believe this PR is causing any problems. All the previous tests have passed and 2 of the 4 autoscaler tests passed indicating the autoscaler is also functional

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-10-21T12:53:02Z

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-10-21T12:56:44Z

@RadekManak: Jira Issue OCPBUGS-1871 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

This error needs to be InvalidMachineConfiguration, because machine goes failed only if it finds error of that type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-05-02T22:40:32Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-provider-azure-container-v4.12.0-202305022015.p0.gcfb76ac.assembly.stream for distgit ose-machine-api-provider-azure.
All builds following this will include this PR.

openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Oct 7, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 7, 2022

openshift-ci bot requested review from Fedosin and JoelSpeed October 7, 2022 14:42

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022

JoelSpeed reviewed Oct 10, 2022

View reviewed changes

RadekManak force-pushed the fix_not_failed_invalid_vmsize branch from ac81a10 to 8edd88c Compare October 13, 2022 11:38

openshift-ci bot assigned JoelSpeed Oct 13, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022

openshift-ci bot requested a review from huali9 October 14, 2022 08:43

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2022

RadekManak force-pushed the fix_not_failed_invalid_vmsize branch from 8edd88c to 6da451e Compare October 14, 2022 10:23

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2022

Fix machine not going failed with invalid vmsize

7fd0017

RadekManak force-pushed the fix_not_failed_invalid_vmsize branch from 6da451e to 7fd0017 Compare October 18, 2022 12:47

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2022

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 19, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022

openshift-merge-robot merged commit cfb76ac into openshift:main Oct 21, 2022

OCPBUGS-1871: Fix machine not going failed with invalid vmsize #36

OCPBUGS-1871: Fix machine not going failed with invalid vmsize #36

Uh oh!

Conversation

RadekManak commented Oct 7, 2022

Uh oh!

openshift-ci-robot commented Oct 7, 2022

Uh oh!

RadekManak commented Oct 7, 2022

Uh oh!

RadekManak commented Oct 7, 2022

Uh oh!

JoelSpeed Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

JoelSpeed commented Oct 13, 2022

Uh oh!

openshift-ci bot commented Oct 13, 2022

Uh oh!

JoelSpeed commented Oct 14, 2022

Uh oh!

openshift-ci-robot commented Oct 14, 2022

Uh oh!

JoelSpeed commented Oct 14, 2022

Uh oh!

openshift-ci-robot commented Oct 14, 2022

Uh oh!

JoelSpeed commented Oct 14, 2022

Uh oh!

openshift-ci bot commented Oct 14, 2022

Uh oh!

JoelSpeed commented Oct 14, 2022

Uh oh!

JoelSpeed commented Oct 14, 2022

Uh oh!

openshift-ci-robot commented Oct 14, 2022

Uh oh!

JoelSpeed commented Oct 17, 2022

Uh oh!

JoelSpeed commented Oct 17, 2022

Uh oh!

JoelSpeed commented Oct 18, 2022

Uh oh!

JoelSpeed commented Oct 18, 2022

Uh oh!

RadekManak commented Oct 18, 2022

Uh oh!

RadekManak commented Oct 18, 2022

Uh oh!

huali9 commented Oct 19, 2022

Uh oh!

JoelSpeed commented Oct 19, 2022

Uh oh!

openshift-ci-robot commented Oct 19, 2022

Uh oh!

JoelSpeed commented Oct 19, 2022

Uh oh!

JoelSpeed commented Oct 20, 2022

Uh oh!

JoelSpeed commented Oct 20, 2022

Uh oh!

JoelSpeed commented Oct 20, 2022

Uh oh!

JoelSpeed commented Oct 21, 2022

Uh oh!

JoelSpeed commented Oct 21, 2022

Uh oh!

openshift-ci bot commented Oct 21, 2022

Uh oh!

openshift-ci bot commented Oct 21, 2022

Uh oh!

openshift-ci-robot commented Oct 21, 2022

Uh oh!

openshift-bot commented May 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone