Skip to content

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#2131

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
gangwgr:backport-kms-v1-4.21
Mar 3, 2026
Merged

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#2131
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
gangwgr:backport-kms-v1-4.21

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented Feb 24, 2026

Backport kms test changes to 4.21

@openshift-ci openshift-ci bot requested review from dgrisonnet and tkashem February 24, 2026 06:36
@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Feb 24, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Feb 24, 2026

/retitle [release-4.21] OCPBUGS-74418: Add KMS test scenarios

@openshift-ci openshift-ci bot changed the title Backport kms test changes to 4.21 [release-4.21] OCPBUGS-74418: Add KMS test scenarios Feb 24, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 24, 2026

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport kms test changes to 4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: gangwgr.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport kms test changes to 4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Feb 24, 2026

/approve

/hold

until we know we would like to backport.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2026
@p0lyn0mial p0lyn0mial added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026
@gangwgr gangwgr force-pushed the backport-kms-v1-4.21 branch from 9f3dc53 to 0f54cba Compare February 24, 2026 12:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
ardaguclu
ardaguclu reviewed Feb 24, 2026
View reviewed changes
test/library/encryption/kms/k8s-mock-plugin/README.md
## Pushing to registry

```bash
docker tag k8s-mock-kms-plugin quay.io/polynomial/k8s-mock-kms-plugin:latest
Copy link
Copy Markdown
Member

@ardaguclu ardaguclu Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to push this to quay.io/openshifttest

Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also, maybe the image should be tied to the release.

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Feb 24, 2026

/retest
/lgtm
/hold

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@gangwgr gangwgr force-pushed the backport-kms-v1-4.21 branch from 0f54cba to b41850f Compare February 25, 2026 05:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 25, 2026

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Feb 27, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, gangwgr, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 3, 2026

/hold cancel

We don't need an SBAR for the TP backport.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 9c30edf into openshift:release-4.21 Mar 3, 2026
4 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 3, 2026

@gangwgr: Jira Issue OCPBUGS-74418: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74418 has not been moved to the MODIFIED state.

Details

In response to this:

Backport kms test changes to 4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Mar 4, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Mar 12, 2026

Fix included in accepted release 4.21.0-0.nightly-2026-03-11-185944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@tkashem tkashem Awaiting requested review from tkashem

+1 more reviewer

@ardaguclu ardaguclu ardaguclu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ardaguclu ardaguclu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gangwgr @ardaguclu @openshift-ci-robot @p0lyn0mial @openshift-merge-robot