Skip to content

[release-4.21] OCPBUGS-74418: Bump library-go to get KMS#2063

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
ardaguclu:fake-bump
Mar 10, 2026
Merged

[release-4.21] OCPBUGS-74418: Bump library-go to get KMS#2063
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
ardaguclu:fake-bump

Conversation

@ardaguclu
Copy link
Copy Markdown
Member

@ardaguclu ardaguclu commented Mar 6, 2026 •
edited
Loading

This PR is manual backport of #2033 to get the changes in openshift/library-go#2138 in order to enable TP v1 KMS functionality in 4.21.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 6, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 6, 2026

@ardaguclu: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

SSIA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 6, 2026

/hold

@openshift-ci openshift-ci bot requested a review from gangwgr March 6, 2026 09:42
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 6, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9e69ae1c-a452-4368-bd64-cd2fc3a78c1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from dinhxuanvu and sanchezl March 6, 2026 09:43
@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 6, 2026

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 6, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 6, 2026

/retest

@ardaguclu ardaguclu mentioned this pull request Mar 6, 2026
Merged
@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 7, 2026

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2026
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 9, 2026
Merged
@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/retest

1 similar comment
@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/retest

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/retitle [release-4.21] OCPBUGS-74418: Bump library-go to get KMS

@openshift-ci openshift-ci bot changed the title [release-4.21] OCPBUGS-74418: Fake bump library-go to get KMS [release-4.21] OCPBUGS-74418: Bump library-go to get KMS Mar 10, 2026
@wangke19
Copy link
Copy Markdown
Contributor

wangke19 commented Mar 10, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, p0lyn0mial, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/retest

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 10, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 10, 2026

@ardaguclu: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/retest

@ardaguclu
Copy link
Copy Markdown
Member Author

ardaguclu commented Mar 10, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2026
This was referenced Mar 10, 2026
Merged
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 10, 2026

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-encryption-single-node c612162 link false /test e2e-gcp-operator-encryption-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c97d65 into openshift:release-4.21 Mar 10, 2026
22 of 23 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 10, 2026

@ardaguclu: Jira Issue OCPBUGS-74418: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-74418 has been moved to the MODIFIED state.

Details

In response to this:

This PR is manual backport of #2033 to get the changes in openshift/library-go#2138 in order to enable TP v1 KMS functionality in 4.21.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu deleted the fake-bump branch March 10, 2026 18:22
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Mar 12, 2026

Fix included in accepted release 4.21.0-0.nightly-2026-03-11-185944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gangwgr gangwgr Awaiting requested review from gangwgr

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@sanchezl sanchezl Awaiting requested review from sanchezl

Assignees

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ardaguclu @openshift-ci-robot @p0lyn0mial @wangke19 @openshift-merge-robot @xingxingxia @gangwgr