Skip to content

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#656

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.21from
gangwgr:kms-tests-4.21
Mar 5, 2026
Merged

[release-4.21] OCPBUGS-74418: Add KMS test scenarios#656
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.21from
gangwgr:kms-tests-4.21

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented Feb 24, 2026

[release-4.21] OCPBUGS-74418: Add KMS test scenarios

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 24, 2026

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.21] OCPBUGS-74418: Add KMS test scenarios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 24, 2026

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: gangwgr.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@gangwgr: This pull request references Jira Issue OCPBUGS-74418, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-68343 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-68343 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @gangwgr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.21] OCPBUGS-74418: Add KMS test scenarios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Feb 25, 2026

@gangwgr this needs to be fixed;

vet: test/e2e-encryption-kms/encryption_kms_test.go:104:132: undefined: library.SupportedStaticEncryptionProviders

p0lyn0mial
p0lyn0mial reviewed Mar 3, 2026
View reviewed changes
go.mod Outdated
replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20241205171354-8006f302fd12

// PR 2131: OCPBUGS-74418 add KMS test helpers (release-4.21)
replace github.com/openshift/library-go => github.com/gangwgr/library-go v0.0.0-20260224124749-0f54cba03ba6
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 3, 2026

/approve

We don't need an SBAR for the TP backport.

@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 3, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 3, 2026
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@p0lyn0mial p0lyn0mial mentioned this pull request Mar 3, 2026
Merged
@gangwgr gangwgr force-pushed the kms-tests-4.21 branch 2 times, most recently from 9c01863 to 929b560 Compare March 3, 2026 14:50
p0lyn0mial
p0lyn0mial reviewed Mar 4, 2026
View reviewed changes
go.mod Outdated
github.com/openshift/build-machinery-go v0.0.0-20250530140348-dc5b2804eeee
github.com/openshift/client-go v0.0.0-20250710075018-396b36f983ee
github.com/openshift/library-go v0.0.0-20250828105733-480b7a0ebfd5
github.com/openshift/library-go v0.0.0-20260225055023-b41850fe248b
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be pinned to 9c30edf843c678f0e6c9fa53fb58c38832bc7d02 ? (xref: https://github.com/openshift/library-go/commits/release-4.21/)

Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but b41850fe248b doesn't bring all deps - this seems wrong, we should pin to 9c30edf843c678f0e6c9fa53fb58c38832bc7d02

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 4, 2026
Merged
@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 5, 2026

The business requires this change.
Other operators in 4.21 already use 1.34.
An alternative would be creating a custom branch and adding the required changes, but this approach may not be sufficient over time.

There is also broader consensus for the changes in this PR (xref: https://redhat-internal.slack.com/archives/C0A0DMK3N7K/p1772637051821339).

/lgtm

@p0lyn0mial
Copy link
Copy Markdown
Contributor

p0lyn0mial commented Mar 5, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gangwgr, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 5, 2026

/test e2e-aws-ovn

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 5, 2026

/verified by @gangwgr

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 5, 2026

@gangwgr: This PR has been marked as verified by @gangwgr.

Details

In response to this:

/verified by @gangwgr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 5, 2026

@gangwgr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-encryption-kms 617dd17 link false /test e2e-gcp-operator-encryption-kms

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 80e95c2 into openshift:release-4.21 Mar 5, 2026
11 of 12 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 5, 2026

@gangwgr: Jira Issue OCPBUGS-74418: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-74418 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.21] OCPBUGS-74418: Add KMS test scenarios

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu mentioned this pull request Mar 6, 2026
Merged
This was referenced Mar 6, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Mar 12, 2026

Fix included in accepted release 4.21.0-0.nightly-2026-03-11-185944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanchezl sanchezl Awaiting requested review from sanchezl

1 more reviewer

@p0lyn0mial p0lyn0mial p0lyn0mial left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xingxingxia xingxingxia

@p0lyn0mial p0lyn0mial

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gangwgr @openshift-ci-robot @ardaguclu @p0lyn0mial @openshift-merge-robot @xingxingxia @wangke19