Skip to content

Comments

UPSTREAM: <carry>: Fix dns endpoints hack (to be squashed)#764

Merged
danwinship merged 1 commit intoopenshift:sdn-4.8-kubernetes-1.21.1from
danwinship:fix-local-dns-hack
May 22, 2021
Merged

UPSTREAM: <carry>: Fix dns endpoints hack (to be squashed)#764
danwinship merged 1 commit intoopenshift:sdn-4.8-kubernetes-1.21.1from
danwinship:fix-local-dns-hack

Conversation

@danwinship
Copy link

Noticed as part of #749. Should be squashed into "Prefer local endpoint for cluster DNS service" on next rebase.

Should be squashed into "Prefer local endpoint for cluster DNS
service" on next rebase.
@danwinship danwinship requested a review from Miciah May 22, 2021 14:25
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 22, 2021
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@openshift-ci
Copy link

openshift-ci bot commented May 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and aojea May 22, 2021 14:25
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2021
@danwinship danwinship merged commit f9da314 into openshift:sdn-4.8-kubernetes-1.21.1 May 22, 2021
@danwinship danwinship deleted the fix-local-dns-hack branch May 22, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants