Bug 1964059: rebase to latest sdn-4.8-kubernetes-1.21.1#305
Bug 1964059: rebase to latest sdn-4.8-kubernetes-1.21.1#305openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
bugzilla/severity-high
|
@danwinship: This pull request references Bugzilla bug 1939968, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
| useEndpointSlices := utilfeature.DefaultFeatureGate.Enabled(features.EndpointSliceProxying) | ||
| if proxyMode == proxyModeUserspace { | ||
| // userspace mode doesn't support endpointslice. | ||
| useEndpointSlices = false |
There was a problem hiding this comment.
is this consistent with your last PR?
There was a problem hiding this comment.
- Note that we have not merged any PRs that affect endpointslice handling.
- If you mean "will it cause any conflicts with proxy: filter/delegate EndpointSlices as well as Endpoints #296", then no, because
cmd/kube-proxy/is only used by the actual kube-proxy binary, not openshift-sdn's embedded copy of kube-proxy. - If you mean "will it cause inconsistency between standalone kube-proxy's behavior and embedded kube-proxy's behavior", then that's not a relevant question. Currently standalone kube-proxy in 4.8 in userspace mode doesn't work, and this fixes it. Embedded kube-proxy in 4.8 in userspace mode already worked (and still works after Bug 1953257: Fix invalid egress IP assignments in sdn-controller #295) and this change doesn't affect it.
|
/retitle Bug 1964059: rebase to latest sdn-4.8-kubernetes-1.21.1 (un-stealing WMCO bug since apparently they have their own distinct vendored copy of kube-proxy) |
openshift-ci
bot
changed the title
|
@danwinship: This pull request references Bugzilla bug 1964059, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@danwinship: All pull requests linked via external trackers have merged: Bugzilla bug 1964059 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
rebase to latest sdn-4.8-kubernetes-1.21.1, including openshift/kubernetes#762 (windows kube-proxy fix) and openshift/kubernetes#764 (fixing kube-proxy hack for local dns)
/cc @aravindhp @Miciah @aojea