Add "local-with-fallback" externalTrafficPolicy hack by danwinship · Pull Request #749 · openshift/kubernetes

danwinship · 2021-05-13T17:05:55Z

If a service has a
"traffic-policy.network.alpha.openshift.io/local-with-fallback"
annotation, then only treat it as "externalTrafficPolicy: Local" when
there are actually running local pods.

That is, if we receive traffic for such a service after the last local
pod terminates, then forward it to a remote pod rather than dropping
it.

~~Also, the existing hack for DNS local pods doesn't actually work because it was modifying allEndpoints after the rest of the code had already ditched allEndpoints in favor of readyEndpoints.~~

/cc @Miciah @dcbw @aojea @smarterclayton

openshift-ci-robot · 2021-05-13T17:06:03Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

7c11fed|UPSTREAM: : implement "prefer local" external traffic policy: does not specify an upstream backport in the commit message
c04514e|UPSTREAM: : Fix dns endpoints hack: does not specify an upstream backport in the commit message

aojea · 2021-05-13T18:25:24Z

how do you do to run the unit tests in proxier_test.go?

EDIT
duh, I was looking into openshift/sdn that vendors the file , hence no tests 🙃

aojea · 2021-05-14T11:36:07Z

pkg/proxy/iptables/proxier.go

for the future us, this is "InternalTrafficPolicy: preferLocal" , right?

aojea · 2021-05-14T11:36:36Z

LGTM

openshift-ci-robot · 2021-05-25T15:01:51Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

c04514e|UPSTREAM: : Fix dns endpoints hack: does not specify an upstream backport in the commit message
c6bf59c|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

…olicy If a service has a "traffic-policy.network.alpha.openshift.io/local-with-fallback" annotation, then only treat it as "externalTrafficPolicy: Local" when there are actually running local pods. That is, if we receive traffic for such a service after the last local pod terminates, then forward it to a remote pod rather than dropping it.

openshift-ci-robot · 2021-05-25T15:07:13Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:07:25Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:07:39Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:07:58Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:08:24Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:09:06Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:10:20Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-25T15:12:38Z

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

01ee4a5|UPSTREAM: : implement "local-with-fallback" external traffic policy: does not specify an upstream backport in the commit message

aojea · 2021-05-26T07:10:36Z

pkg/proxy/iptables/proxier.go

+	localWithFallback bool
 }

+const localWithFallbackAnnotation = "traffic-policy.network.alpha.openshift.io/local-with-fallback"


there is going to be an "official" annotation, service.kubernetes.io/topology-aware-routing
https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2433-topology-aware-hints#configuration

do we want to make it more official?

service.kubernetes.io/topology-aware-routing = local-with-fallback

aojea · 2021-05-26T07:13:54Z

/lgtm
only bike shedding comments :)

openshift-ci · 2021-05-26T07:15:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from Miciah, aojea, dcbw and smarterclayton May 13, 2021 17:05

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 13, 2021

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021

danwinship added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 13, 2021

aojea reviewed May 14, 2021

View reviewed changes

smarterclayton mentioned this pull request May 14, 2021

DO NOT MERGE: Test the prefer-local behavior openshift/sdn#301

Closed

danwinship mentioned this pull request May 22, 2021

UPSTREAM: <carry>: Fix dns endpoints hack (to be squashed) #764

Merged

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2021

danwinship force-pushed the prefer-local branch from 7c11fed to c6bf59c Compare May 25, 2021 15:01

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 25, 2021

danwinship changed the title ~~WIP Add "prefer-local" externalTrafficPolicy hack~~ Add "local-with-fallback" externalTrafficPolicy hack May 25, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2021

openshift-ci-robot removed the backports/validated-commits Indicates that all commits come to merged upstream PRs. label May 25, 2021

danwinship force-pushed the prefer-local branch from c6bf59c to 01ee4a5 Compare May 25, 2021 15:06

aojea reviewed May 26, 2021

View reviewed changes

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2021

openshift-ci bot assigned aojea May 26, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2021

danwinship merged commit fbaadca into openshift:sdn-4.8-kubernetes-1.21.1 Jun 1, 2021

danwinship deleted the prefer-local branch June 1, 2021 18:58

Comments

Conversation

danwinship commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 13, 2021

Uh oh!

aojea commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aojea May 14, 2021

Choose a reason for hiding this comment

Uh oh!

aojea commented May 14, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

openshift-ci-robot commented May 25, 2021

Uh oh!

aojea May 26, 2021

Choose a reason for hiding this comment

Uh oh!

aojea commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented May 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danwinship commented May 13, 2021 •

edited

Loading

aojea commented May 13, 2021 •

edited

Loading

aojea commented May 26, 2021 •

edited

Loading