Bug 1949105: Reenable NetworkPolicy test. by msherif1234 · Pull Request #734 · openshift/kubernetes

msherif1234 · 2021-05-05T14:07:47Z

Renable NetworkPolicy test between server and client on any port for specific protocol which was
incorrectly disabled by #655

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com

openshift-ci-robot · 2021-05-05T14:07:54Z

@msherif1234: This pull request references Bugzilla bug 1949105, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1949105: Renable NetworkPolicy test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-05-05T14:07:56Z

@msherif1234: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

4b6c450|Renable NetworkPolicy test between server and client on any port for specific protocol.: does not specify an upstream backport in the commit message

openshift-ci-robot · 2021-05-05T14:08:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msherif1234
To complete the pull request process, please assign soltysh after the PR has been reviewed.
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danwinship · 2021-05-05T14:15:09Z

Renable NetworkPolicy test between server and client on any port for specific protocol which was
incorrectly disabled by #382

it was disabled in #655

danwinship

to make the "make verify" checks happy, your commit message summary has to be prefixed with UPSTREAM: <carry>:. So UPSTREAM: <carry>: Reenable NetworkPolicy test ...

openshift-hack/e2e/annotate/rules.go

openshift-ci-robot · 2021-05-05T14:24:43Z

@msherif1234: This pull request references Bugzilla bug 1949105, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1949105: Renable NetworkPolicy test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-05-05T14:27:42Z

@msherif1234: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

4b6c450|Renable NetworkPolicy test between server and client on any port for specific protocol.: does not specify an upstream backport in the commit message
7a4173b|UPSTREAM: : Reenable NetworkPolicy test.: does not specify an upstream backport in the commit message

msherif1234 · 2021-05-05T14:29:51Z

/test verify-commits

msherif1234 · 2021-05-05T14:36:42Z

/test verify-commits

openshift-ci-robot · 2021-05-05T14:43:43Z

@msherif1234: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

08ed105|UPSTREAM: : Reenable NetworkPolicy test: does not specify an upstream backport in the commit message

msherif1234 · 2021-05-05T14:46:03Z

/test verify-commits

msherif1234 · 2021-05-05T17:54:09Z

/retest

msherif1234 · 2021-05-05T21:23:21Z

/retest

msherif1234 · 2021-05-06T10:26:57Z

/retest

msherif1234 · 2021-05-06T13:43:07Z

/test e2e-gcp

msherif1234 · 2021-05-06T22:57:49Z

/retest

msherif1234 · 2021-05-07T12:02:52Z

/retest

danwinship · 2021-05-07T16:57:52Z

@msherif1234 ah, you also need to run ./openshift-hack/update-test-annotations.sh

Note that for some reason it will only generate the right output if your working directory is ${GOPATH}/src/k8s.io/kubernetes, not ${GOPATH}/src/github.com/openshift/kubernetes so you may have to move things around temporarily

openshift-ci-robot · 2021-05-07T17:12:37Z

@msherif1234: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

08ed105|UPSTREAM: : Reenable NetworkPolicy test: does not specify an upstream backport in the commit message
f696b63|Added update annotation changes: does not specify an upstream backport in the commit message

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

openshift-ci-robot · 2021-05-07T17:13:34Z

@msherif1234: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

58e0728|UPSTREAM: : Reenable NetworkPolicy test: does not specify an upstream backport in the commit message

msherif1234 · 2021-05-07T20:28:02Z

/retest

danwinship · 2021-05-08T12:27:55Z

/lgtm
/assign @soltysh

k8s-e2e-gcp logs show that the test is now unskipped and passing:

{"msg":"PASSED [sig-network] Netpol [LinuxOnly] NetworkPolicy between server and client should enforce ingress policy allowing any port traffic to a server on a specific protocol [Feature:NetworkPolicy] [Feature:UDP] [Suite:openshift/conformance/parallel] [Suite:k8s]","total":-1,"completed":24,"skipped":159,"failed":0}

msherif1234 · 2021-05-10T12:23:05Z

/retest

msherif1234 · 2021-05-10T15:06:05Z

/test e2e-aws-fips

soltysh

/approve

openshift-ci · 2021-05-11T11:46:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, msherif1234, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

msherif1234 · 2021-05-11T13:32:40Z

/test k8s-e2e-gcp

openshift-bot · 2021-05-11T13:32:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-05-11T15:58:58Z

@msherif1234: All pull requests linked via external trackers have merged:

openshift/kubernetes#734

Bugzilla bug 1949105 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1949105: Reenable NetworkPolicy test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 5, 2021

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2021

openshift-ci-robot requested a review from zhaozhanqi May 5, 2021 14:07

openshift-ci-robot requested review from mfojtik and soltysh May 5, 2021 14:08

danwinship reviewed May 5, 2021

View reviewed changes

openshift-hack/e2e/annotate/rules.go Outdated Show resolved Hide resolved

msherif1234 requested a review from danwinship May 5, 2021 14:28

msherif1234 changed the title ~~Bug 1949105: Renable NetworkPolicy test~~ Bug 1949105: UPSTREAM: <carry>: Reenable NetworkPolicy test. May 5, 2021

msherif1234 force-pushed the bz_1949105 branch from 7a4173b to 08ed105 Compare May 5, 2021 14:43

msherif1234 changed the title ~~Bug 1949105: UPSTREAM: <carry>: Reenable NetworkPolicy test.~~ Bug 1949105: Reenable NetworkPolicy test. May 5, 2021

UPSTREAM: <carry>: Reenable NetworkPolicy test

58e0728

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>

msherif1234 force-pushed the bz_1949105 branch from f696b63 to 58e0728 Compare May 7, 2021 17:13

openshift-ci bot assigned soltysh and danwinship May 8, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2021

soltysh approved these changes May 11, 2021

View reviewed changes

soltysh removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 11, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021

openshift-merge-robot merged commit c4bd6f9 into openshift:master May 11, 2021

Conversation

msherif1234 commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

danwinship commented May 5, 2021

Uh oh!

danwinship left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

msherif1234 commented May 5, 2021

Uh oh!

msherif1234 commented May 5, 2021

Uh oh!

openshift-ci-robot commented May 5, 2021

Uh oh!

msherif1234 commented May 5, 2021

Uh oh!

msherif1234 commented May 5, 2021

Uh oh!

msherif1234 commented May 5, 2021

Uh oh!

msherif1234 commented May 6, 2021

Uh oh!

msherif1234 commented May 6, 2021

Uh oh!

msherif1234 commented May 6, 2021

Uh oh!

msherif1234 commented May 7, 2021

Uh oh!

danwinship commented May 7, 2021

Uh oh!

openshift-ci-robot commented May 7, 2021

Uh oh!

openshift-ci-robot commented May 7, 2021

Uh oh!

msherif1234 commented May 7, 2021

Uh oh!

danwinship commented May 8, 2021

Uh oh!

msherif1234 commented May 10, 2021

Uh oh!

msherif1234 commented May 10, 2021

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented May 11, 2021

Uh oh!

msherif1234 commented May 11, 2021

Uh oh!

openshift-bot commented May 11, 2021

Uh oh!

openshift-ci bot commented May 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

msherif1234 commented May 5, 2021 •

edited

Loading