Skip to content

Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase#655

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:un-disable-networkpolicy
Apr 28, 2021
Merged

Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase#655
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danwinship:un-disable-networkpolicy

Conversation

@danwinship
Copy link

@danwinship danwinship commented Apr 10, 2021

The rebase disabled all of [Feature:NetworkPolicy]. This is bad. Also, no bug was filed about it. This is worse.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 10, 2021
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship danwinship force-pushed the un-disable-networkpolicy branch from f15f1aa to 934dc21 Compare April 10, 2021 19:37
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship
Copy link
Author

/test k8s-e2e-gcp

@danwinship danwinship force-pushed the un-disable-networkpolicy branch from 934dc21 to ad0219b Compare April 13, 2021 12:55
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship
Copy link
Author

/test k8s-e2e-gcp

1 similar comment
@danwinship
Copy link
Author

/test k8s-e2e-gcp

@danwinship
Copy link
Author

/assign @marun @sttts
CI is still on fire, but the last k8s-e2e-gcp run passed all of the non-skipped [Feature:NetworkPolicy] tests so any further problems are not the fault of this PR, and this really ought to go in to make sure we don't regress.

@danwinship
Copy link
Author

/retest

1 similar comment
@danwinship
Copy link
Author

/retest

@danwinship danwinship force-pushed the un-disable-networkpolicy branch from ad0219b to 280e860 Compare April 23, 2021 22:01
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

@danwinship
Copy link
Author

/retest

@danwinship danwinship changed the title Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase Apr 24, 2021
@openshift-ci-robot
Copy link

@danwinship: This pull request references Bugzilla bug 1953127, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 24, 2021
@openshift-ci-robot
Copy link

@danwinship: This pull request references Bugzilla bug 1953127, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link

sttts commented Apr 26, 2021

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2021
@sttts sttts removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 26, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3bed56d into openshift:master Apr 28, 2021
@openshift-ci-robot
Copy link

@danwinship: All pull requests linked via external trackers have merged:

Bugzilla bug 1953127 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1953127: Re-enable [Feature:NetworkPolicy] tests which were wrongly disabled in rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants