Fix networking-related test exclusions#382
Fix networking-related test exclusions#382openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
|
I guess this repo probably doesn't have the magic to revendor itself into origin and run CI with that? So maybe I should submit a WIP PR there... |
danwinship
force-pushed
the
fix-network-test-exclusions
branch
2 times, most recently
from
dac4ad0 to
eb4c4e9
Compare
danwinship
force-pushed
the
fix-network-test-exclusions
branch
from
eb4c4e9 to
42ec323
Compare
|
/retest |
|
/lgtm |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@danwinship hmm, are the regexes failing or something? k8s-e2e-gcp fails on the network tests that you're moving around here. |
|
oh I guess we could just have the |
The NetworkPolicy tests work by trying to connect to a service by its name, which means that for the tests that involved creating egress policies, it had to always create an extra rule allowing egress for DNS, but this assumed that DNS was running on UDP port 53. If it was running somewhere else (eg if you changed the CoreDNS pods to use port 5353 to avoid needing to give them the NET_BIND_SERVICE capability) then the NetworkPolicy tests would fail. Fix this by making the tests connect to their services by IP rather than by name, and removing all the DNS special-case rules. There are other tests that ensure that Service DNS works.
danwinship
force-pushed
the
fix-network-test-exclusions
branch
from
42ec323 to
bd3bb6f
Compare
|
@danwinship You'll need to run |
Tests that fail on openshift-sdn specifically should be tagged as such, so that they don't also get skipped when running under ovn-kubernetes or third-party network plugins.
danwinship
force-pushed
the
fix-network-test-exclusions
branch
from
bd3bb6f to
6232c70
Compare
oh, no, I had done that (well, I did |
|
/retest |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, dcbw, marun, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 participants
The networking-related test skips got broken in the 1.19 rebase. We have logic set up to let us to distinguish "tests that don't pass when using openshift-sdn" and "tests that don't pass when using ovn-kubernetes", but a bunch of tests just got marked as "tests that OpenShift can't pass no matter what" in the 1.19 rebase (and so specifically, we are now skipping tests in the ovn-kubernetes jobs that should not be getting skipped, because ovn-kubernetes does implement those features, and we want to test that).
Also, for some reason, the network-plugin-specific annotations were left in origin even though they only apply to upstream k8s tests. I have moved them to openshift/kubernetes in this PR, assuming that the comments in openshift/origin are correct, and that we are supposed to have all k8s skips here and all origin skips in origin. Once this merges I'll submit another PR to remove the redundant skips in origin.